[GitHub] [hadoop-ozone] dchitlangia commented on a change in pull request #62: HDDS-2335. Params not included in AuditMessage

[GitBox <gi...@apache.org>]

dchitlangia commented on a change in pull request #62: HDDS-2335. Params not included in AuditMessage
URL: https://github.com/apache/hadoop-ozone/pull/62#discussion_r336815546
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/audit/AuditMessage.java
 ##########
 @@ -120,7 +120,7 @@ public Builder withException(Throwable ex){
     public AuditMessage build(){
       AuditMessage auditMessage = new AuditMessage();
       auditMessage.message = "user=" + this.user + " | ip=" + this.ip + " | " +
-          "op=" + this.op + " | " + "ret=" + this.ret;
+          "op=" + this.op + " " + this.params + " | " + "ret=" + this.ret;
 
 Review comment:
   @bharatviswa504 `params=` is not required. the old format was something like:
   `..... | op=OPERATION_NAME [params] |......`
   So changes from @adoroszlai are fine.
   
   This seems to have been broken by HDDS-2323. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org