You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/12/17 17:29:21 UTC
[PR] Fix few clarifications in provider release process [airflow]
potiuk opened a new pull request, #36267:
URL: https://github.com/apache/airflow/pull/36267
There are few steps missing in the provider release process if you followed it meticulously - the working directory was not changed to the AIRFLOW_ROOT and main should be checked out right before we should create branch to update providers metadata.
This PR fixes it.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versiosn) from remote repository and then do a few things regarding constraint files.
But I agree that it order to get the latest source for the script running from main seems safer I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versiosn) from remote repository and then do a few things regarding constraint files.
But I agree that in order to get the latest source for breeze running from main seems safer I would say. (for core we run from main and let breeze checkout the branches, so sources are up to date)
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versiosn) from remote repository and then do a few things regarding constraint files.
But I agree that in order to get the latest source for breeze running from main seems safer I would say. (for core we run from main and let breeze checkout the branches, so sources are up to date for breeze)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versions) from remote repository and then do a few things regarding constraint files.
But I agree that in order to get the latest source for breeze running from main seems safer I would say. (for core we run from main and let breeze checkout the branches, so sources are up to date for breeze)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versiosn) from remote repository and then do a few things regarding constraint files.
But I agree that in order to get the latest source for breeze running from main seems safer I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429229259
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
cool so if we want to run it from main we need to remove the comment as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versions) from remote repository and then do a few things regarding constraint files.
But I agree that in order to get the latest source for breeze, running from main seems safer I would say. (for core we run from main and let breeze checkout the branches, so sources are up to date for breeze)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags (for airflow versiosn) from remote repository.
But I agree that it order to get the latest source for the script running from main seems safer I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429224373
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I asked @pierrejeambrun about this. he said we shouldn't do it from main branch but from the tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36267:
URL: https://github.com/apache/airflow/pull/36267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429226210
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
I don't think it is of big importance here because we fetch tags from remote repository.
But I agree that it order to get the latest source for the script running from main seems safer I would say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429225303
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
Note the
`Make sure you create the following branch from the git tag (steps before) and not from main!` comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429224764
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
Hmm. That's strange - I'd say we should always run PRs from main :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix few clarifications in provider release process [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36267:
URL: https://github.com/apache/airflow/pull/36267#discussion_r1429235895
##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -1110,6 +1111,8 @@ Make sure you create the following branch from the git tag (steps before) and no
```shell script
cd ${AIRFLOW_REPO_ROOT}
+git checkout main
+git pull
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org