You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/07 08:36:48 UTC
[I] [Studio][Bug] Validate Apache instance type before persistence [rocketmq-dashboard]
Aias00 opened a new issue, #1237:
URL: https://github.com/apache/rocketmq-dashboard/issues/1237
## Problem
The `rmq_instance.type` column is `NOT NULL`, but `InstanceService.createApacheInstance` only validates name and endpoint. A request without `type` reaches persistence and fails as a database error instead of a structured client error.
## Expected behavior
Apache instance creation must reject a missing type with HTTP 400 before persistence. Valid `DIRECT` and `PROXY` values remain unchanged.
## Scope
Track 1 instance registration validation. This is intentionally separate from #1194, which validates endpoint syntax.
## Evidence
- `server/src/main/java/org/apache/rocketmq/studio/instance/InstanceService.java:98`
- `server/src/main/resources/db/schema.sql:26`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Validate Apache instance type before persistence [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1237:
URL: https://github.com/apache/rocketmq-dashboard/issues/1237#issuecomment-5299374875
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Validate Apache instance type before persistence [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1237:
URL: https://github.com/apache/rocketmq-dashboard/issues/1237#issuecomment-5215151067
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
The reported issue has been verified against the current codebase on the `rocketmq-studio` branch.
**Root Cause:** `InstanceService.createApacheInstance()` (line ~98) validates `name` and `endpoint` but does not validate `type`. The `rmq_instance.type` column is `NOT NULL` in the schema, so a request without `type` passes validation and fails at the persistence layer with an unstructured database error instead of a clean HTTP 400.
**Impact:** Clients receive an opaque 500 error from the database layer instead of a meaningful validation error. This makes API debugging harder and violates the principle of fail-fast validation.
**Severity:** medium
**Affected files:**
- `InstanceService.java:98` — `createApacheInstance()` missing type validation
- `schema.sql:26` — `type` column is `NOT NULL`
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Validate Apache instance type before persistence [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #1237: [Studio][Bug] Validate Apache instance type before persistence
URL: https://github.com/apache/rocketmq-dashboard/issues/1237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org