[GitHub] [camel-website] zregvart commented on a change in pull request #401: Camel-15202 : Add the custom scrollbar for nav menu panel

[GitBox <gi...@apache.org>]

zregvart commented on a change in pull request #401:
URL: https://github.com/apache/camel-website/pull/401#discussion_r446067343



##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -54,6 +54,8 @@
   /* nav */
   --nav-background: var(--panel-background);
   --nav-border-color: var(--color-smoke-50);
+  --nav-scrollbar-color: var(--color-gray-10);
+  --nav-scrollbar-active-color: var(--color-gray-50);

Review comment:
       Can we make this on same lines and with the same name as in the [Default Antora UI](https://gitlab.com/antora/antora-ui-default/-/blob/master/src/css/vars.css), this would make it easier to rebase.

##########
File path: antora-ui-camel/src/css/nav.css
##########
@@ -118,6 +118,32 @@ html.is-clipped--nav {
   overflow-y: auto;
 }
 
+.nav-menu::-webkit-scrollbar {
+  width: 0.42rem;
+}
+
+.nav-menu::-webkit-scrollbar-track {
+  background: var(--nav-scrollbar-color);
+  border-radius: 3.125rem;
+}
+
+.nav-menu::-webkit-scrollbar-thumb {
+  background: var(--nav-scroll-thumb-color);
+  border-radius: 3.125rem;
+}
+
+.nav-menu::-webkit-scrollbar-thumb:hover,
+.nav-menu::-webkit-scrollbar-thumb:active {
+  background: var(--nav-scrollbar-active-color);
+}
+
+@media screen and (max-width: 1023px) {
+  .nav-menu::-webkit-scrollbar {
+    width: 0;
+    background: transparent;
+  }
+}
+

Review comment:
       If we could make this changes align with [the Default Antora UI](https://gitlab.com/antora/antora-ui-default/-/blob/master/src/css/nav.css#L91-105), that would be awesome, much easier to rebase then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org