[GitHub] [airflow] omar-binary edited a comment on issue #14541: Airflow upgrade_check gives false positives on DbApi functions implementations check

[GitBox <gi...@apache.org>]

omar-binary edited a comment on issue #14541:
URL: https://github.com/apache/airflow/issues/14541#issuecomment-863915504


   I can still see it in V1.3.0
   
   Apache Airflow version:
   1.10.15
   
   ```
   airflow@d9b97fe4d7cc:/opt/airflow$ airflow upgrade_check --version
   1.3.0
   airflow@d9b97fe4d7cc:/opt/airflow$ airflow upgrade_check --config /opt/airflow/plugins/upgrade.yml
   Using config file: /opt/airflow/plugins/upgrade.yml
   
   ====================================================================================== STATUS ======================================================================================
   
   Check for latest versions of apache-airflow and checker...................................................................................................................SUCCESS
   Remove airflow.AirflowMacroPlugin class...................................................................................................................................SUCCESS
   Ensure users are not using custom metaclasses in custom operators.........................................................................................................SUCCESS
   Chain between DAG and operator not allowed................................................................................................................................SUCCESS
   Connection.conn_type is not nullable......................................................................................................................................SUCCESS
   Custom Executors now require full path....................................................................................................................................SUCCESS
   /home/airflow/.local/lib/python3.8/site-packages/airflow/providers/google/cloud/hooks/bigquery.py:119: DeprecationWarning: This method will be deprecated. Please use `BigQueryHook.get_client` method
     warnings.warn(
   Hooks that run DB functions must inherit from DBApiHook...................................................................................................................FAIL
   Fernet is enabled by default..............................................................................................................................................SUCCESS
   GCP service account key deprecation.......................................................................................................................................SUCCESS
   Unify hostname_callable option in core section............................................................................................................................SUCCESS
   Changes in import paths of hooks, operators, sensors and others...........................................................................................................SUCCESS
   Legacy UI is deprecated by default........................................................................................................................................SUCCESS
   Logging configuration has been moved to new section.......................................................................................................................SUCCESS
   Removal of Mesos Executor.................................................................................................................................................SUCCESS
   No additional argument allowed in BaseOperator............................................................................................................................SUCCESS
   SendGrid email uses old airflow.contrib module............................................................................................................................SUCCESS
   Check Spark JDBC Operator default connection name.........................................................................................................................SUCCESS
   Changes in import path of remote task handlers............................................................................................................................SUCCESS
   Connection.conn_id is not unique..........................................................................................................................................SUCCESS
   Use CustomSQLAInterface instead of SQLAInterface for custom data models...................................................................................................SUCCESS
   Found 1 problem.
   
   ================================================================================= RECOMMENDATIONS ==================================================================================
   
   Hooks that run DB functions must inherit from DBApiHook
   -------------------------------------------------------
   Hooks that run DB functions must inherit from DBApiHook instead of BaseHook
   
   Problems:
   
     1.  Class <class 'airflow.providers.google.cloud.hooks.bigquery.BigQueryHook'> incorrectly implements the function get_pandas_df while inheriting from BaseHook. Please make this class inherit from airflow.hooks.db_api_hook.DbApiHook instead
   
   airflow@d9b97fe4d7cc:/opt/airflow$ 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org