You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "Musayev, Ilya" <im...@webmd.net> on 2012/10/11 18:51:06 UTC
bug in cloud-set-guest-sshkey.in
Hi Guys,
Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
Change:
if [ -n $SSHKEY_SERVER_IP ]
to
if [ -n "$SSHKEY_SERVER_IP" ]
Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
Regards
ilya
RE: bug in cloud-set-guest-sshkey.in
Posted by "Musayev, Ilya" <im...@webmd.net>.
Never mind, I had to cd into a dir. sorry
-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net]
Sent: Thursday, October 11, 2012 2:44 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: bug in cloud-set-guest-sshkey.in
Need help with getting git working and creating a "mybranch" - I admit, I'm git noob
Following steps on
http://incubator.apache.org/cloudstack/develop/non-contributors.html
After I did
git clone https://git-wip-us.apache.org/repos/asf/incubator-cloudstack.git
[root@cloud04t-ops-08 a]# git checkout -b mybranch
fatal: Not a git repository (or any of the parent directories): .git
Please help, what am I missing?
Thanks
ilya
-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net]
Sent: Thursday, October 11, 2012 2:21 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: bug in cloud-set-guest-sshkey.in
I guess I rushed and did a brick and mortar approach. I will try to redo.
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Thursday, October 11, 2012 2:05 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: bug in cloud-set-guest-sshkey.in
Hi ilya,
Instructions for submitting patches are here:
http://incubator.apache.org/cloudstack/develop/non-contributors.html
Thanks for the help!
On Thu, Oct 11, 2012 at 1:58 PM, Musayev, Ilya <im...@webmd.net> wrote:
> Hi Sudha
>
> Is there a guide for first time committers or can I just submit a patch created with diff.
>
> Thanks
> ilya
>
> -----Original Message-----
> From: Sudha Ponnaganti [mailto:sudha.ponnaganti@citrix.com]
> Sent: Thursday, October 11, 2012 1:31 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: bug in cloud-set-guest-sshkey.in
>
> Ilya,
>
> Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
>
> Thanks
> /sudha
>
> -----Original Message-----
> From: Musayev, Ilya [mailto:imusayev@webmd.net]
> Sent: Thursday, October 11, 2012 9:51 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: bug in cloud-set-guest-sshkey.in
>
> Hi Guys,
>
>
>
> Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
>
>
>
> Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
>
>
>
> Change:
>
> if [ -n $SSHKEY_SERVER_IP ]
>
> to
>
> if [ -n "$SSHKEY_SERVER_IP" ]
>
>
>
> Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
>
>
>
> I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
>
>
>
> Regards
>
> ilya
>
>
>
>
RE: bug in cloud-set-guest-sshkey.in
Posted by "Musayev, Ilya" <im...@webmd.net>.
Need help with getting git working and creating a "mybranch" - I admit, I'm git noob
Following steps on
http://incubator.apache.org/cloudstack/develop/non-contributors.html
After I did
git clone https://git-wip-us.apache.org/repos/asf/incubator-cloudstack.git
[root@cloud04t-ops-08 a]# git checkout -b mybranch
fatal: Not a git repository (or any of the parent directories): .git
Please help, what am I missing?
Thanks
ilya
-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net]
Sent: Thursday, October 11, 2012 2:21 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: bug in cloud-set-guest-sshkey.in
I guess I rushed and did a brick and mortar approach. I will try to redo.
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Thursday, October 11, 2012 2:05 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: bug in cloud-set-guest-sshkey.in
Hi ilya,
Instructions for submitting patches are here:
http://incubator.apache.org/cloudstack/develop/non-contributors.html
Thanks for the help!
On Thu, Oct 11, 2012 at 1:58 PM, Musayev, Ilya <im...@webmd.net> wrote:
> Hi Sudha
>
> Is there a guide for first time committers or can I just submit a patch created with diff.
>
> Thanks
> ilya
>
> -----Original Message-----
> From: Sudha Ponnaganti [mailto:sudha.ponnaganti@citrix.com]
> Sent: Thursday, October 11, 2012 1:31 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: bug in cloud-set-guest-sshkey.in
>
> Ilya,
>
> Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
>
> Thanks
> /sudha
>
> -----Original Message-----
> From: Musayev, Ilya [mailto:imusayev@webmd.net]
> Sent: Thursday, October 11, 2012 9:51 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: bug in cloud-set-guest-sshkey.in
>
> Hi Guys,
>
>
>
> Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
>
>
>
> Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
>
>
>
> Change:
>
> if [ -n $SSHKEY_SERVER_IP ]
>
> to
>
> if [ -n "$SSHKEY_SERVER_IP" ]
>
>
>
> Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
>
>
>
> I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
>
>
>
> Regards
>
> ilya
>
>
>
>
RE: bug in cloud-set-guest-sshkey.in
Posted by "Musayev, Ilya" <im...@webmd.net>.
I guess I rushed and did a brick and mortar approach. I will try to redo.
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Thursday, October 11, 2012 2:05 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: bug in cloud-set-guest-sshkey.in
Hi ilya,
Instructions for submitting patches are here:
http://incubator.apache.org/cloudstack/develop/non-contributors.html
Thanks for the help!
On Thu, Oct 11, 2012 at 1:58 PM, Musayev, Ilya <im...@webmd.net> wrote:
> Hi Sudha
>
> Is there a guide for first time committers or can I just submit a patch created with diff.
>
> Thanks
> ilya
>
> -----Original Message-----
> From: Sudha Ponnaganti [mailto:sudha.ponnaganti@citrix.com]
> Sent: Thursday, October 11, 2012 1:31 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: bug in cloud-set-guest-sshkey.in
>
> Ilya,
>
> Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
>
> Thanks
> /sudha
>
> -----Original Message-----
> From: Musayev, Ilya [mailto:imusayev@webmd.net]
> Sent: Thursday, October 11, 2012 9:51 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: bug in cloud-set-guest-sshkey.in
>
> Hi Guys,
>
>
>
> Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
>
>
>
> Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
>
>
>
> Change:
>
> if [ -n $SSHKEY_SERVER_IP ]
>
> to
>
> if [ -n "$SSHKEY_SERVER_IP" ]
>
>
>
> Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
>
>
>
> I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
>
>
>
> Regards
>
> ilya
>
>
>
>
Re: bug in cloud-set-guest-sshkey.in
Posted by Chip Childers <ch...@sungard.com>.
Hi ilya,
Instructions for submitting patches are here:
http://incubator.apache.org/cloudstack/develop/non-contributors.html
Thanks for the help!
On Thu, Oct 11, 2012 at 1:58 PM, Musayev, Ilya <im...@webmd.net> wrote:
> Hi Sudha
>
> Is there a guide for first time committers or can I just submit a patch created with diff.
>
> Thanks
> ilya
>
> -----Original Message-----
> From: Sudha Ponnaganti [mailto:sudha.ponnaganti@citrix.com]
> Sent: Thursday, October 11, 2012 1:31 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: bug in cloud-set-guest-sshkey.in
>
> Ilya,
>
> Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
>
> Thanks
> /sudha
>
> -----Original Message-----
> From: Musayev, Ilya [mailto:imusayev@webmd.net]
> Sent: Thursday, October 11, 2012 9:51 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: bug in cloud-set-guest-sshkey.in
>
> Hi Guys,
>
>
>
> Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
>
>
>
> Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
>
>
>
> Change:
>
> if [ -n $SSHKEY_SERVER_IP ]
>
> to
>
> if [ -n "$SSHKEY_SERVER_IP" ]
>
>
>
> Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
>
>
>
> I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
>
>
>
> Regards
>
> ilya
>
>
>
>
RE: bug in cloud-set-guest-sshkey.in
Posted by "Musayev, Ilya" <im...@webmd.net>.
Hi Sudha
Is there a guide for first time committers or can I just submit a patch created with diff.
Thanks
ilya
-----Original Message-----
From: Sudha Ponnaganti [mailto:sudha.ponnaganti@citrix.com]
Sent: Thursday, October 11, 2012 1:31 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: bug in cloud-set-guest-sshkey.in
Ilya,
Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
Thanks
/sudha
-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net]
Sent: Thursday, October 11, 2012 9:51 AM
To: cloudstack-dev@incubator.apache.org
Subject: bug in cloud-set-guest-sshkey.in
Hi Guys,
Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
Change:
if [ -n $SSHKEY_SERVER_IP ]
to
if [ -n "$SSHKEY_SERVER_IP" ]
Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
Regards
ilya
RE: bug in cloud-set-guest-sshkey.in
Posted by Sudha Ponnaganti <su...@citrix.com>.
Ilya,
Can you log a defect @ https://issues.apache.org/jira/browse/CLOUDSTACK and then commit patch for it
Thanks
/sudha
-----Original Message-----
From: Musayev, Ilya [mailto:imusayev@webmd.net]
Sent: Thursday, October 11, 2012 9:51 AM
To: cloudstack-dev@incubator.apache.org
Subject: bug in cloud-set-guest-sshkey.in
Hi Guys,
Found a bug that prevents getting the SSHKEY_SERVER_IP in cloud-set-guest-sshkey.in
Please add double quotes when doing variable check, it's a best practice in bash and should not break anything - in this case it fixes the issue and SSHKEY_SERVER_IP actually has value. Previously, eventhough the value was present, it would not show up when bash did var check ( -n).
Change:
if [ -n $SSHKEY_SERVER_IP ]
to
if [ -n "$SSHKEY_SERVER_IP" ]
Tested on GNU bash version 4.1.2, CentOS/RedHat 6.2
I know this is not the best way to submit a patch, but since I've customized cloud-set-guest-sshkey.in a lot, my diff output won't be relevant to the rest of community.
Regards
ilya