You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/25 15:33:46 UTC
[GitHub] [camel-k] christophd opened a new issue, #3849: Create normal service when knative-service trait is disabled
christophd opened a new issue, #3849:
URL: https://github.com/apache/camel-k/issues/3849
Camel K automatically creates Knative services for integrations when Knative serving is available on the cluster. This is done in the knative-service trait.
In case for some reason knative-service trait is disabled (either globally on the cluster or explicitly on the integration) Camel K should fallback to a normal service. At the moment when knative-service trait is disabled but Knative serving is available on the cluster no service at all is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1452825426
This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1328603571
It's related to how the profile is detected for an integration. Whenever you have Knative serving in the cluster, integrations are by default resolved to `Knative` profile. And Service trait is enabled only when the profile is either `Kubernetes` or `OpenShift`.
You should be able to fix the issue by explicitly assign one of them for an integration instead of letting it unspecified in an env where Knative serving is installed already.
So I think the questions are two-fold:
1. Does it make sense to disable Knative Service trait under `Knatvie` profile? And does it make sense to create a service when the profile is `Knative`?
2. Should we improve the current profile detection logic? If yes, how?
https://github.com/apache/camel-k/blob/v1.10.3/pkg/controller/integration/platform_setup.go#L68-L89
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by GitBox <gi...@apache.org>.
christophd commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1334919043
Setting the profile for an integration may not be what we want. A different profile may disable the whole Knative feature portfolio and we only need to disable the knative-service feature. Maybe we want to keep knative eventing and ksink injection but only disable knative-service trait for some reason.
I think the profile detection is fine as it is. but we need to have a decent fallback when a specific trait gets disabled for some reason. At the moment we do not create a service at all which is not good. we need to fallback to a normal service when knative-service gets disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1453130726
It seems so, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by GitBox <gi...@apache.org>.
claudio4j commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1335198614
My understanding is the profile helps driving the traits and other logic in camel-k-operator, but there may be issues related to competing traits, and this knative-service/service is one of them, mutually exclusive traits. Christoph's comment is also right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1453119510
@claudio4j I think this one has already been fixed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #3849: Create normal service when knative-service trait is disabled
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #3849: Create normal service when knative-service trait is disabled
URL: https://github.com/apache/camel-k/issues/3849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #3849: Create normal service when knative-service trait is disabled
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #3849:
URL: https://github.com/apache/camel-k/issues/3849#issuecomment-1328712520
cc @claudio4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org