You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/24 19:59:20 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #3598: net/ip: bypass UDP input only when the device address is invalid

patacongo commented on pull request #3598:
URL: https://github.com/apache/incubator-nuttx/pull/3598#issuecomment-826145734


   Many of the most important technical comments have ended up on the companion PR #3601.  If you are evaluating that, please read my comments/suggestions with regard to:
   
   1. Removing al IPv6 changes.  I think it is premature to make these IPv6 changes which do not appear complete or correct to me.  DHCPv6 is a completely different creature and blindly copying the IPv4 changes is, I believe, in correct.
   
   2. I recommended a more unifying design based on the existing support of the SO_BINDTODEVICE socket option.   That option is intended to handle this case and the IPv4 change is really most correctly an part of the behavior of that socket option.  That socket option works on IPv6 just as well without slamming in arbitrary cloned logic.
   
   Again, see #3601 for better description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org