You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/05 11:03:55 UTC
[GitHub] [rocketmq-schema-registry] ferrirW opened a new pull request, #26: simplify schema record id to user
ferrirW opened a new pull request, #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26
id + version => schemaRecordId
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207553122
@ferrirW please pay attention to the CI build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] ferrirW commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
ferrirW commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207586426
> The schemaRecordId is returned to users but it is not shown where this recordId needs to be used. I think the way to get schema is still by SchemaId or by SchemaVersion, not by recordId.
The Id is used to serialize message. Old version (SchemaId and SchemaVersion) will taking too much space(128B), new version (SchemaRecordId) only use 64B.
And SchemaRecordId is consisted of SchemaId and SchemaVersion with customed snowflake algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207559030
The schemaRecordId is returned to users but it is not shown where this recordId needs to be used.
I think the way to get schema is still by SchemaId or by SchemaVersion, not by recordId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] ferrirW commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
ferrirW commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207596482
> > > The schemaRecordId is returned to users but it is not shown where this recordId needs to be used. I think the way to get schema is still by SchemaId or by SchemaVersion, not by recordId.
> >
> >
> > I can add it to the document, SchemaRecordId is consisted of SchemaId and SchemaVersion with customed snowflake algorithm.
> > And Actually, the user doesn't need to care about the RecordId, it's more about the Client using the RecordId to serialize the message. Old version (SchemaId and SchemaVersion) will taking too much space(128B), new version (SchemaRecordId) only use 64B. @MatrixHB
>
> Got it. So we need to add a method to get schema by RecordId in `SchemaRegistryClient`, in order to support message ser/de, right?
Yes, this method will be add by @humkum later, and client serde will also be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] MatrixHB commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
MatrixHB commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207594078
> > The schemaRecordId is returned to users but it is not shown where this recordId needs to be used. I think the way to get schema is still by SchemaId or by SchemaVersion, not by recordId.
>
> I can add it to the document, SchemaRecordId is consisted of SchemaId and SchemaVersion with customed snowflake algorithm.
>
> And Actually, the user doesn't need to care about the RecordId, it's more about the Client using the RecordId to serialize the message. Old version (SchemaId and SchemaVersion) will taking too much space(128B), new version (SchemaRecordId) only use 64B. @MatrixHB
Got it. So we need to add a method to get schema by RecordId in `SchemaRegistryClient`, which is used in client Ser/de, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26#issuecomment-1207619325
# [Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (819fea2) into [main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/77cb8c65788801a6d07de9b21cd2c8b35680881c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (77cb8c6) will **decrease** coverage by `0.31%`.
> The diff coverage is `27.27%`.
```diff
@@ Coverage Diff @@
## main #26 +/- ##
============================================
- Coverage 10.51% 10.19% -0.32%
Complexity 25 25
============================================
Files 35 35
Lines 723 726 +3
Branches 39 39
============================================
- Hits 76 74 -2
- Misses 641 646 +5
Partials 6 6
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...chema/registry/core/service/SchemaServiceImpl.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc2NoZW1hL3JlZ2lzdHJ5L2NvcmUvc2VydmljZS9TY2hlbWFTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/registry/client/serde/avro/AvroDeserializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2F2cm8vQXZyb0Rlc2VyaWFsaXplci5qYXZh) | `72.72% <100.00%> (-0.81%)` | :arrow_down: |
| [...ema/registry/client/serde/avro/AvroSerializer.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/26/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9zY2hlbWEvcmVnaXN0cnkvY2xpZW50L3NlcmRlL2F2cm8vQXZyb1NlcmlhbGl6ZXIuamF2YQ==) | `72.72% <100.00%> (-0.81%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] duhenglucky merged pull request #26: simplify schema record id to user
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #26:
URL: https://github.com/apache/rocketmq-schema-registry/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org