You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/06/03 12:42:11 UTC

[GitHub] [zeppelin] Reamer opened a new pull request, #4378: [ZEPPELIN-5748] Use of checkCaseAndConvert in constructor

Reamer opened a new pull request, #4378:
URL: https://github.com/apache/zeppelin/pull/4378

   ### What is this PR for?
   This pull request primarily changes the constructor of NoteAuth so that the configuration ZEPPELIN_USERNAME_FORCE_LOWERCASE also applies to existing notes.
   
   ### What type of PR is it?
   - Bug Fix
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5748
   
   ### How should this be tested?
   * via CI
   
   ### Questions:
   * Does the licenses files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer merged pull request #4378: [ZEPPELIN-5750] Add tests and polish NoteAuth

Posted by GitBox <gi...@apache.org>.
Reamer merged PR #4378:
URL: https://github.com/apache/zeppelin/pull/4378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4378: [ZEPPELIN-5748] Use of checkCaseAndConvert in constructor

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4378:
URL: https://github.com/apache/zeppelin/pull/4378#issuecomment-1149496268

   This PR is incorrect because the group names are also lowercase. I will adjust the PR and add more test methods to simulate the case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org