You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "jackyyyyyssss (via GitHub)" <gi...@apache.org> on 2024/01/11 08:18:02 UTC
[PR] [Improvement][E2E] fix bug javatask classpath and add e2e javatask case [dolphinscheduler]
jackyyyyyssss opened a new pull request, #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
fix javatask classpath no class-path and add e2e java test
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] fix bug javatask classpath and add e2e javatask case [dolphinscheduler]
Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1886640147
> It's better to split bugfix and feature into two PR. @jackyyyyyssss
ok .I will submit another PR to fix the bug in the Javatask classpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1888216824
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469) **Quality Gate passed**
The SonarCloud Quality Gate passed, but some issues were introduced.
[1 New issue](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_coverage&view=list)
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#discussion_r1450057656
##########
dolphinscheduler-standalone-server/src/main/docker/Dockerfile:
##########
@@ -15,7 +15,7 @@
# limitations under the License.
#
-FROM eclipse-temurin:8-jre
+FROM eclipse-temurin:8-jdk
Review Comment:
Why did you change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss commented on code in PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#discussion_r1450106213
##########
dolphinscheduler-standalone-server/src/main/docker/Dockerfile:
##########
@@ -15,7 +15,7 @@
# limitations under the License.
#
-FROM eclipse-temurin:8-jre
+FROM eclipse-temurin:8-jdk
Review Comment:
Because the JRE image does not have the installation of the JavaC command, the Javatask needs to be compiled before execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1888672746
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1888211127
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`309c8c9`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/309c8c97a9b9003244496dedc7861a5026f9441a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.11% compared to head [(`f613d5d`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15469?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.11%.
> Report is 1 commits behind head on dev.
> :exclamation: Current head f613d5d differs from pull request most recent head 4ef2269. Consider uploading reports for the commit 4ef2269 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15469 +/- ##
=========================================
Coverage 38.11% 38.11%
+ Complexity 4697 4696 -1
=========================================
Files 1299 1299
Lines 44774 44736 -38
Branches 4797 4774 -23
=========================================
- Hits 17066 17052 -14
+ Misses 25861 25837 -24
Partials 1847 1847
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15469?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1888217301
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469) **Quality Gate passed**
The SonarCloud Quality Gate passed, but some issues were introduced.
[3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_coverage&view=list)
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#discussion_r1450107852
##########
dolphinscheduler-standalone-server/src/main/docker/Dockerfile:
##########
@@ -15,7 +15,7 @@
# limitations under the License.
#
-FROM eclipse-temurin:8-jre
+FROM eclipse-temurin:8-jdk
Review Comment:
I got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] add e2e javatask case [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15469:
URL: https://github.com/apache/dolphinscheduler/pull/15469#issuecomment-1888674602
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15469&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15469&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15469)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][E2E] fix bug javatask classpath and add e2e javatask case [dolphinscheduler]
Posted by "jackyyyyyssss (via GitHub)" <gi...@apache.org>.
jackyyyyyssss closed pull request #15469: [Improvement][E2E] fix bug javatask classpath and add e2e javatask case
URL: https://github.com/apache/dolphinscheduler/pull/15469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org