You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by GitBox <gi...@apache.org> on 2021/11/15 20:28:01 UTC

[GitHub] [ant] azotcsit opened a new pull request #169: junitlauncher - Improved extensibility capabilities for formatters

azotcsit opened a new pull request #169:
URL: https://github.com/apache/ant/pull/169


   ### Context
   I'm working on migration of Cassandra to JUnit5 (https://issues.apache.org/jira/browse/CASSANDRA-16630). Our test running code is heavily customized and based on custom formatters ([XML](https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/CassandraXMLJUnitResultFormatter.java), [Brief](https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/CassandraBriefJUnitResultFormatter.java)).  one of the features we rely on is "extension" attribute (https://github.com/apache/ant/blob/master/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java#L77). In fact these are just extensions of the default _ant-junit_ formatters. _ant-junitlauncher_ provides similar default implementations called _legacy-xml_ and _legacy-brief_. Unfortunately, we cannot extend and modify these implementations to incorporate our custom logic. The purpose of this PR is to make existing implementations extensible and flexible to re-use.
   
   ### Behavior
   This PR does not change any existing behavior.
   
   ### Summary of the changes
   1. TBD


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] [ant] azotcsit closed pull request #169: junitlauncher - Improved extensibility capabilities for formatters

Posted by GitBox <gi...@apache.org>.
azotcsit closed pull request #169:
URL: https://github.com/apache/ant/pull/169


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] [ant] azotcsit commented on a change in pull request #169: junitlauncher - Improved extensibility capabilities for formatters

Posted by GitBox <gi...@apache.org>.
azotcsit commented on a change in pull request #169:
URL: https://github.com/apache/ant/pull/169#discussion_r773913282



##########
File path: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
##########
@@ -43,7 +43,7 @@
 /**
  * Contains some common behaviour that's used by our internal {@link TestResultFormatter}s
  */
-abstract class AbstractJUnitResultFormatter implements TestResultFormatter {
+public abstract class AbstractJUnitResultFormatter implements TestResultFormatter {

Review comment:
       It is impossible to have abstract class protected, so it is marked as public. The methods are protected, not public.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


[GitHub] [ant] azotcsit commented on pull request #169: junitlauncher - Improved extensibility capabilities for formatters

Posted by GitBox <gi...@apache.org>.
azotcsit commented on pull request #169:
URL: https://github.com/apache/ant/pull/169#issuecomment-1009962932


   Closing as per the discussion on the dev mail list: https://lists.apache.org/thread/2v8l95fwh0sgz0vlgqcf1rpd88swf3pv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org