[GitHub] john-bodley commented on a change in pull request #4408: Add link on how to get permission to permission error.

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #4408: Add link on how to get permission to permission error.
URL: https://github.com/apache/incubator-superset/pull/4408#discussion_r168329983
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -64,7 +64,14 @@
 ACCESS_REQUEST_MISSING_ERR = __(
     'The access requests seem to have been deleted')
 USER_MISSING_ERR = __('The user seems to have been deleted')
-DATASOURCE_ACCESS_ERR = __("You don't have access to this datasource")
+perms_instruction_link = config.get('PERMISSION_INSTRUCTIONS_LINK')
+if perms_instruction_link:
+    DATASOURCE_ACCESS_ERR = __(
+        "You don't have access to this datasource. <a href='{}'>How to gain access.</a>"
 
 Review comment:
   I think this is fine. If you wanted to truncate the length of the message maybe something like 
   > You don't have access to this datasource (Gain Access)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services