[GitHub] [calcite] zoudan commented on a diff in pull request #3290: [CALCITE-5782] Add TO_HEX and FROM_HEX functions (enabled in BigQuery library)

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3290:
URL: https://github.com/apache/calcite/pull/3290#discussion_r1254112706


##########
site/_docs/reference.md:
##########
@@ -2752,6 +2752,8 @@ BigQuery's type system uses confusingly different names for types and functions:
 | b | FROM_BASE32(string)                            | Returns the decoded result of a base-32 *string* as a string
 | m | TO_BASE64(string)                              | Converts the *string* to base-64 encoded form and returns a encoded string
 | b m | FROM_BASE64(string)                          | Returns the decoded result of a base-64 *string* as a string
+| b | TO_HEX(binary)                                 | Converts *binary* into a hexadecimal varchar
+| b | FROM_HEX(varchar)                              | Converts a hexadecimal-encoded *varchar* into bytes

Review Comment:
   Should we use types in the related libs or in calcite? I think it is the latter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org