You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/30 11:25:17 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request, #6076: [IOTDB-3335] Redundant data recovered by wal in multi-leader consensus
HeimingZ opened a new pull request, #6076:
URL: https://github.com/apache/iotdb/pull/6076
Some data will be recovered wrongly because wal is kept, but memtable id still starts from 0 when using multi-leader consensus. So, I recover memtable id when using multi-leader consensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #6076: [IOTDB-3335] Redundant data recovered by wal in multi-leader consensus
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #6076:
URL: https://github.com/apache/iotdb/pull/6076#discussion_r884807508
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/DataRegion.java:
##########
@@ -3541,7 +3542,9 @@ public IDTable getIdTable() {
}
public IWALNode getWALNode() {
- if (!config.isClusterMode()) {
+ if (!config
+ .getDataRegionConsensusProtocolClass()
+ .equals(ConsensusFactory.MultiLeaderConsensus)) {
throw new UnsupportedOperationException();
}
Review Comment:
Is there any problem if started as a standalone IoTDB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a diff in pull request #6076: [IOTDB-3335] Redundant data recovered by wal in multi-leader consensus
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on code in PR #6076:
URL: https://github.com/apache/iotdb/pull/6076#discussion_r884859025
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/DataRegion.java:
##########
@@ -3541,7 +3542,9 @@ public IDTable getIdTable() {
}
public IWALNode getWALNode() {
- if (!config.isClusterMode()) {
+ if (!config
+ .getDataRegionConsensusProtocolClass()
+ .equals(ConsensusFactory.MultiLeaderConsensus)) {
throw new UnsupportedOperationException();
}
Review Comment:
No, only multi-leader consensus will invoke this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #6076: [IOTDB-3335] Redundant data recovered by wal in multi-leader consensus
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #6076:
URL: https://github.com/apache/iotdb/pull/6076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org