You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/12 05:19:50 UTC
[GitHub] rtaneja1 commented on issue #940: [NETBEANS-1074] Module Review
web.struts
rtaneja1 commented on issue #940: [NETBEANS-1074] Module Review web.struts
URL: https://github.com/apache/incubator-netbeans/pull/940#issuecomment-429207343
Changes look fine to me, please make sure test results are same as before changes. Also run ant -Dcluster.config=full verify-libs-and-licenses to check that there are no warnings in this module.
Not sure about license for struts-config_1_2-custom.dtd, struts-config_1_3-custom.dtd, not included in this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists