You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2012/11/04 21:38:19 UTC
svn commit: r1405630 - in /maven/plugin-tools/trunk:
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/
maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/
Author: rfscholte
Date: Sun Nov 4 20:38:18 2012
New Revision: 1405630
URL: http://svn.apache.org/viewvc?rev=1405630&view=rev
Log:
String.indexOf(char) is faster than String.indexOf(String).
Modified:
maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
maven/plugin-tools/trunk/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java
Modified: maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java?rev=1405630&r1=1405629&r2=1405630&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java Sun Nov 4 20:38:18 2012
@@ -445,7 +445,7 @@ public class PluginDescriptorGenerator
String roleHint = null;
- int posRoleHintSeparator = role.indexOf( "#" );
+ int posRoleHintSeparator = role.indexOf( '#' );
if ( posRoleHintSeparator > 0 )
{
roleHint = role.substring( posRoleHintSeparator + 1 );
Modified: maven/plugin-tools/trunk/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java?rev=1405630&r1=1405629&r2=1405630&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-tools-javadoc/src/main/java/org/apache/maven/tools/plugin/javadoc/AbstractMojoTaglet.java Sun Nov 4 20:38:18 2012
@@ -149,7 +149,7 @@ public abstract class AbstractMojoTaglet
{
String nextToken = token.nextToken();
- if ( nextToken.indexOf( "=" ) == -1 )
+ if ( nextToken.indexOf( '=' ) == -1 )
{
// using pattern: @annotation <annotationValue>
tagValue = nextToken;
@@ -178,7 +178,7 @@ public abstract class AbstractMojoTaglet
{
String nextToken = token.nextToken();
- if ( nextToken.indexOf( "=" ) == -1 )
+ if ( nextToken.indexOf( '=' ) == -1 )
{
// using pattern: @annotation <annotationValue>
continue;
@@ -385,7 +385,7 @@ public abstract class AbstractMojoTaglet
*/
private static List<String> getOnlyValues( String text )
{
- if ( text.indexOf( "|" ) == -1 )
+ if ( text.indexOf( '|' ) == -1 )
{
return Collections.emptyList();
}