You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/03 04:53:26 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #31449: [SPARK-34326][CORE][SQL] Fix UTs added in SPARK-31793 depending on the length of temp path

HeartSaVioR commented on pull request #31449:
URL: https://github.com/apache/spark/pull/31449#issuecomment-772226875


   Sorry there looked to be some case I haven't taken care of. (The log file doesn't say about the actual path, but I'm suspecting the difference between path without schema vs with schema - `file:///`.)
   
   Instead of struggling with thinking of all possible cases, I think it's more appropriate if we ensure the test always verifies the case path truncation happens and only one path is accepted. Other cases are covered by UtilsSuite.
   
   Please take a look at this again. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org