You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Denes Arvay <de...@cloudera.com> on 2017/01/02 14:19:16 UTC
Re: Review Request 51802: FLUME-2976: Exception when JMS source tries
to connect to a Weblogic server without authentication
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51802/
-----------------------------------------------------------
(Updated Jan. 2, 2017, 3:19 p.m.)
Review request for Flume, Bal�zs Don�t Bessenyei, Mike Percy, and Attila Simon.
Changes
-------
Introduced `TestMode` enum.
Bugs: FLUME-2976
https://issues.apache.org/jira/browse/FLUME-2976
Repository: flume-git
Description
-------
If no `userName` and `passwordFile` is set for the JMS source it sets the password to `Optional("")`. This leads to an exception in the weblogic jndi context implementation when trying to connect to a weblogic jms server.
Diffs (updated)
-----
flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java 7631827
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java 53cc09a
Diff: https://reviews.apache.org/r/51802/diff/
Testing
-------
- `flume-ng-sources/flume-jms-source` tests pass
- `TestIntegrationActiveMQ` is now a parameterized test to test with and without authentication.
Thanks,
Denes Arvay
Re: Review Request 51802: FLUME-2976: Exception when JMS source tries
to connect to a Weblogic server without authentication
Posted by Ferenc Szabo via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51802/#review204057
-----------------------------------------------------------
Ship it!
Ship It!
- Ferenc Szabo
On Jan. 2, 2017, 2:19 p.m., Denes Arvay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51802/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2017, 2:19 p.m.)
>
>
> Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon.
>
>
> Bugs: FLUME-2976
> https://issues.apache.org/jira/browse/FLUME-2976
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> If no `userName` and `passwordFile` is set for the JMS source it sets the password to `Optional("")`. This leads to an exception in the weblogic jndi context implementation when trying to connect to a weblogic jms server.
>
>
> Diffs
> -----
>
> flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java 7631827
> flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java 53cc09a
>
>
> Diff: https://reviews.apache.org/r/51802/diff/2/
>
>
> Testing
> -------
>
> - `flume-ng-sources/flume-jms-source` tests pass
> - `TestIntegrationActiveMQ` is now a parameterized test to test with and without authentication.
>
>
> Thanks,
>
> Denes Arvay
>
>