[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1853: fix memory leak in wrapper field #1852
URL: https://github.com/apache/incubator-doris/pull/1853#discussion_r327421905
 
 

 ##########
 File path: be/src/olap/wrapper_field.h
 ##########
 @@ -112,7 +113,10 @@ class WrapperField {
     //include fixed and variable length and null bytes
     size_t _length;
     size_t _var_length;
+    // used for copy
     Arena _arena;
+    // memory for string type field
+    std::unique_ptr<char> _string_content;
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org