You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "twalthr (via GitHub)" <gi...@apache.org> on 2025/05/27 08:38:20 UTC
[PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
twalthr opened a new pull request, #26600:
URL: https://github.com/apache/flink/pull/26600
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on PR #26600:
URL: https://github.com/apache/flink/pull/26600#issuecomment-2912381226
Thank you @snuyanzin. I will add the Chinese docs now, I just wanted to wait until the feedback has settled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "gustavodemorais (via GitHub)" <gi...@apache.org>.
gustavodemorais commented on code in PR #26600:
URL: https://github.com/apache/flink/pull/26600#discussion_r2109122212
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/process/AbstractProcessTableOperator.java:
##########
@@ -322,14 +315,18 @@ private void setTimeContext() {
}
private void setCollectors() {
- if (tableSemantics == null || tableSemantics.passColumnsThrough()) {
- evalCollector = new PassAllCollector(output, changelogMode);
+ final int tableCount = tableSemantics.size();
+ if (tableCount == 0
+ || tableSemantics.stream().anyMatch(RuntimeTableSemantics::passColumnsThrough)) {
+ assert tableCount <= 1;
+ // Collect with all input columns (potentially none)
+ evalCollector = new PassAllCollector(output, changelogMode, 1);
} else {
- evalCollector =
- new PassPartitionKeysCollector(
- output, changelogMode, tableSemantics.partitionByColumns());
+ // Collect with partition keys for each table
+ evalCollector = new PassPartitionKeysCollector(output, changelogMode, tableSemantics);
}
- onTimerCollector = new PassAllCollector(output, changelogMode);
+ // Collect with partition keys for each table
Review Comment:
nit: is this comment correct? Seems to be the same for PassPartitionKeysCollector which collects with the partition key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #26600:
URL: https://github.com/apache/flink/pull/26600#discussion_r2109396093
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/process/AbstractProcessTableOperator.java:
##########
@@ -322,14 +315,18 @@ private void setTimeContext() {
}
private void setCollectors() {
- if (tableSemantics == null || tableSemantics.passColumnsThrough()) {
- evalCollector = new PassAllCollector(output, changelogMode);
+ final int tableCount = tableSemantics.size();
+ if (tableCount == 0
+ || tableSemantics.stream().anyMatch(RuntimeTableSemantics::passColumnsThrough)) {
+ assert tableCount <= 1;
+ // Collect with all input columns (potentially none)
+ evalCollector = new PassAllCollector(output, changelogMode, 1);
} else {
- evalCollector =
- new PassPartitionKeysCollector(
- output, changelogMode, tableSemantics.partitionByColumns());
+ // Collect with partition keys for each table
+ evalCollector = new PassPartitionKeysCollector(output, changelogMode, tableSemantics);
}
- onTimerCollector = new PassAllCollector(output, changelogMode);
+ // Collect with partition keys for each table
Review Comment:
In general the comment is correct. The result is described here, just using a different collector to achieve the same. I will adjust the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #26600:
URL: https://github.com/apache/flink/pull/26600#discussion_r2108849045
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java:
##########
@@ -362,6 +362,17 @@ public class OptimizerConfigOptions {
+ "it receives incremental accumulators and outputs incremental results). "
+ "In this way, we can reduce some state overhead and resources. Default is enabled.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer> TABLE_OPTIMIZER_PTF_MAX_TABLES =
+ key("table.optimizer.ptf.max-tables")
+ .intType()
+ .defaultValue(20)
Review Comment:
Not many vendors support multi input PTFs. Maybe even just Oracle. In any case, the limit has been discussed with @pnowojski and should be reasonable default that our engine might still be able to handle. All we wanted to avoid is immediately supporting Integer.MAX_VALUE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr merged PR #26600:
URL: https://github.com/apache/flink/pull/26600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26600:
URL: https://github.com/apache/flink/pull/26600#issuecomment-2911678200
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "258dc17ad6fe8b727ec354d746e36ba21af5fd96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "258dc17ad6fe8b727ec354d746e36ba21af5fd96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 258dc17ad6fe8b727ec354d746e36ba21af5fd96 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37763][table] Support multiple table arguments in PTFs [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26600:
URL: https://github.com/apache/flink/pull/26600#discussion_r2108845092
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java:
##########
@@ -362,6 +362,17 @@ public class OptimizerConfigOptions {
+ "it receives incremental accumulators and outputs incremental results). "
+ "In this way, we can reduce some state overhead and resources. Default is enabled.");
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer> TABLE_OPTIMIZER_PTF_MAX_TABLES =
+ key("table.optimizer.ptf.max-tables")
+ .intType()
+ .defaultValue(20)
Review Comment:
out of curiosity do we know if there is any other vendor offering PTF feature and what limit do they have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org