[GitHub] [camel-karavan] mrinalsharma commented on a diff in pull request #574: Alert user that the Deployment is running. Deployment should be dele…

[GitBox <gi...@apache.org>]

mrinalsharma commented on code in PR #574:
URL: https://github.com/apache/camel-karavan/pull/574#discussion_r1055604958


##########
karavan-app/src/main/webui/src/projects/ProjectsPage.tsx:
##########
@@ -80,7 +83,23 @@ export class ProjectsPage extends React.Component<Props, State> {
     }
 
     onProjectDelete = (project: Project) => {
-        this.setState({isDeleteModalOpen: true, projectToDelete: project})
+        KaravanApi.getProjectPipelineStatus(project.projectId, this.props.config.environment, (status?: PipelineStatus) => {
+            if(status === undefined){
+                this.setState({isDeleteModalOpen: true, projectToDelete: project})
+            }else if(status?.result ==="Running"){
+                this.setState({isPodRunningModalOpen: true, projectToDelete: project})
+            }else if(status?.result ==="Succeeded"){

Review Comment:
   Should the new pipeline run not delete the old Deployment first?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org