You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2016/06/02 23:16:00 UTC

Review Request 48190: HIVE-13933

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48190/
-----------------------------------------------------------

Review request for hive and Hari Sankar Sivarama Subramaniyan.


Bugs: HIVE-13933
    https://issues.apache.org/jira/browse/HIVE-13933


Repository: hive-git


Description
-------

If numThreads=0 then do operations serially


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ff5c858 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ee6c564 

Diff: https://reviews.apache.org/r/48190/diff/


Testing
-------

Regression suite.


Thanks,

Ashutosh Chauhan

Re: Review Request 48190: HIVE-13933

Posted by Lefty Leverenz <le...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48190/#review136020
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2401 - 2402)
<https://reviews.apache.org/r/48190/#comment201023>

    I'm guessing the change of SizeValidator from 1L to 0L makes it possible to specify a value of 0, in order to turn off parallel file moves.  If that's right, please explain in the description.


- Lefty Leverenz


On June 2, 2016, 11:16 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48190/
> -----------------------------------------------------------
> 
> (Updated June 2, 2016, 11:16 p.m.)
> 
> 
> Review request for hive and Hari Sankar Sivarama Subramaniyan.
> 
> 
> Bugs: HIVE-13933
>     https://issues.apache.org/jira/browse/HIVE-13933
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> If numThreads=0 then do operations serially
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ff5c858 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ee6c564 
> 
> Diff: https://reviews.apache.org/r/48190/diff/
> 
> 
> Testing
> -------
> 
> Regression suite.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>