You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Alessandro Solimando (Jira)" <ji...@apache.org> on 2022/10/11 08:28:00 UTC
[jira] [Comment Edited] (CALCITE-5306) Remove JDK15/16 EOL non-LTS JDKs in CI
[ https://issues.apache.org/jira/browse/CALCITE-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613606#comment-17613606 ]
Alessandro Solimando edited comment on CALCITE-5306 at 10/11/22 8:27 AM:
-------------------------------------------------------------------------
I agree [~julianhyde], my comment was partial/misleading, I intend to keep testing against {_}latest{_}, I plan to drop _JDK15/16_ as they are non-LTS and EOL versions.
Concerning {_}latest{_}, _forbiddenAPIs_ does not yet support _JDK19_ (I tried to upgrade from 3.1 to its latest version, 3.4, but no luck), so I added a note and will revisit the upgrade of latest to _JDK19_ as soon as it will possible, for now we will keep testing against {_}JDK18{_}.
I took the chance to do a CI inventory, here is the current status and what I plan to change:
* Travis:
** openjdk8 + custom TZ + GUAVA 19.0
** openjdk11 + CHECKERFRAMEWORK=Y + GUAVA 29.0-jre
** openjdk11 + ERRORPRONE=Y + GUAVA=31.1-jre
** openjdk11 + custom TZ
** openjdk15 + GUAVA 31.1-jre => openjdk17 + GUAVA 31.1-jre
** openjdk16 + GUAVA=31.1-jre => openjdk18 + GUAVA=31.1-jre # this is "latest"
* GitHub Actions:
** Windows (JDK 8)
** Linux (JDK 11), Avatica main
** -Linux (OpenJ9 8) => macOS (OpenJ9 8) # fixing the job name, it's using a macOS image, not a linux one- <- removed
** macOS (JDK 18)
** Error Prone (JDK 11)
** CheckerFramework (JDK 11)
** Linux (JDK 8) Slow Tests
** Linux (JDK 8) Druid Tests
* Appveyor:
** Windows jdk8 => Windows jdk17 (since jdk8 on windows is already covered in GitHub actions)
** Windows jdk16 => -Windows jdk18- EDIT: as per [appveyor documentation|https://www.appveyor.com/docs/windows-images-software/#java] they support up to JDK17, so I would use JDK11 here
I guess that AppVeyor has been introduced because Travis does not support windows-based images. Now that we also use GitHub actions which has such support, we could probably drop {_}AppVeyor{_}, similarly to what Apache ORC did: ORC-1073 and INFRA-22692
To not overload this ticket, I will address the issue in a separate discussion/ticket.
was (Author: asolimando):
I agree [~julianhyde], my comment was partial/misleading, I intend to keep testing against {_}latest{_}, I plan to drop _JDK15/16_ as they are non-LTS and EOL versions.
Concerning {_}latest{_}, _forbiddenAPIs_ does not yet support _JDK19_ (I tried to upgrade from 3.1 to its latest version, 3.4, but no luck), so I added a note and will revisit the upgrade of latest to _JDK19_ as soon as it will possible, for now we will keep testing against {_}JDK18{_}.
I took the chance to do a CI inventory, here is the current status and what I plan to change:
* Travis:
** openjdk8 + custom TZ + GUAVA 19.0
** openjdk11 + CHECKERFRAMEWORK=Y + GUAVA 29.0-jre
** openjdk11 + ERRORPRONE=Y + GUAVA=31.1-jre
** openjdk11 + custom TZ
** openjdk15 + GUAVA 31.1-jre => openjdk17 + GUAVA 31.1-jre
** openjdk16 + GUAVA=31.1-jre => openjdk18 + GUAVA=31.1-jre # this is "latest"
* GitHub Actions:
** Windows (JDK 8)
** Linux (JDK 11), Avatica main
** Linux (OpenJ9 8) => macOS (OpenJ9 8) # fixing the job name, it's using a macOS image, not a linux one
** macOS (JDK 18)
** Error Prone (JDK 11)
** CheckerFramework (JDK 11)
** Linux (JDK 8) Slow Tests
** Linux (JDK 8) Druid Tests
* Appveyor:
** Windows jdk8 => Windows jdk17 (since jdk8 on windows is already covered in GitHub actions)
** Windows jdk16 => -Windows jdk18- EDIT: as per [appveyor documentation|https://www.appveyor.com/docs/windows-images-software/#java] they support up to JDK17, so I would use JDK11 here
I guess that AppVeyor has been introduced because Travis does not support windows-based images. Now that we also use GitHub actions which has such support, we could probably drop {_}AppVeyor{_}, similarly to what Apache ORC did: ORC-1073 and INFRA-22692
To not overload this ticket, I will address the issue in a separate discussion/ticket.
> Remove JDK15/16 EOL non-LTS JDKs in CI
> --------------------------------------
>
> Key: CALCITE-5306
> URL: https://issues.apache.org/jira/browse/CALCITE-5306
> Project: Calcite
> Issue Type: Test
> Components: tests
> Affects Versions: 1.32.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Following [this discussion|https://lists.apache.org/thread/txh3n7r1sygqs69084z9m7g6r1hjbmn8] in the ML, we agreed on supporting only LTS JDK versions plus latest in our test environment (Github actions, AppVeyor and Travis).
> JDK 8 for the usual reasons is an exception to the rule and will be kept.
> All non-LTS EOL versions will be either upgraded to the next LTS version ({_}e.g.{_}, JDK 15 will be replaced by JDK 17) or {_}latest{_}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)