[GitHub] [geode] upthewaterspout opened pull request #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["upthewaterspout (GitHub)" <gi...@apache.org>]

We have a lot of Awaitility calls in our tests. Each test was picking
its own timeout. That lead to some tests picking too small of a timeout
and failing spuriously.

With this change, all tests will use a new factory,
GeodeAwaility.await(), rather than Awaitility.await(). This new factory
sets a default timeout of 5 minutes. It also sets a sensible pollDelay
and pollInterval.

The custom timeouts used in all tests have been removed, in favor of
this new factory, except for a couple of tests that had waits greater
than 5 minutes.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dhemery commented on pull request #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["dhemery (GitHub)" <gi...@apache.org>]

I would prefer to get rid of the `GeodeAwaitility` scoping here, and instead start the expression with `await()`. (But I wouldn't hold up the merge for that.)

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on issue #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["upthewaterspout (GitHub)" <gi...@apache.org>]

@dhemery 

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dhemery commented on pull request #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["dhemery (GitHub)" <gi...@apache.org>]

I would prefer to get rid of the scoping here. (But I wouldn't hold up the merge for that.)

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot commented on issue #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["rhoughton-pivot (GitHub)" <gi...@apache.org>]

With the introduction of GeodeAwaitility, should there be a static analysis rule that checks for use of raw Awaitility in other places? How do we help people do the right thing in their tests?

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2572: GEODE-5424: Changing all awaitility calls to use consistent timings

["jinmeiliao (GitHub)" <gi...@apache.org>]

+1 to use GeodeAwaitility to impose a new set of defaults.

[ Full content available at: https://github.com/apache/geode/pull/2572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org