You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2009/07/07 13:17:14 UTC
[jira] Created: (THRIFT-535) Twisted Thrift protocol max length is
too small
Twisted Thrift protocol max length is too small
-----------------------------------------------
Key: THRIFT-535
URL: https://issues.apache.org/jira/browse/THRIFT-535
Project: Thrift
Issue Type: Bug
Components: Library (Python)
Reporter: Esteve Fernandez
Assignee: Esteve Fernandez
Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-535) Twisted Thrift protocol max length is
too small
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-535:
------------------------------------
Attachment: thrift_535.patch
This sets MAX_LENGTH to 2 ** 31 (32-bit messages, minus sign)
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-535) Twisted Thrift protocol max length
is too small
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732663#action_12732663 ]
Esteve Fernandez commented on THRIFT-535:
-----------------------------------------
Just committed the patch, thanks for testing it Woosuk
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-535) Twisted Thrift protocol max length
is too small
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732670#action_12732670 ]
Esteve Fernandez commented on THRIFT-535:
-----------------------------------------
Thanks for pointing it out David, I just fixed it in the latest revision.
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-535) Twisted Thrift protocol max length
is too small
Posted by "Woosuk Suh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732454#action_12732454 ]
Woosuk Suh commented on THRIFT-535:
-----------------------------------
This patch resolved my problem TTransportException when reading somewhat big contents through TTwisted, using thrift.
Reading the description and referring to my experience, all the contents that raised TTransportException was bigger than 99999 bytes.
I hope this patch to be applied ASAP :)
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-535) Twisted Thrift protocol max length
is too small
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732667#action_12732667 ]
David Reiss commented on THRIFT-535:
------------------------------------
Sorry to jump in late on this one, but the biggest number that you can put in a signed 32-bit value is 2^31-1
dreiss@dr-mbp:master:dreiss$ printf '#include <limits.h>\nINT_MAX\n' | cpp | tail -n1
2147483647
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-535) Twisted Thrift protocol max length is
too small
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez resolved THRIFT-535.
-------------------------------------
Resolution: Fixed
Fixed in revision #795176.
> Twisted Thrift protocol max length is too small
> -----------------------------------------------
>
> Key: THRIFT-535
> URL: https://issues.apache.org/jira/browse/THRIFT-535
> Project: Thrift
> Issue Type: Bug
> Components: Library (Python)
> Reporter: Esteve Fernandez
> Assignee: Esteve Fernandez
> Attachments: thrift_535.patch
>
>
> Both ThriftClientProtocol and ThriftServerProtocol have a limit on 99999 bytes per message. This is due to Twisted's IntNStringReceiver's MAX_LENGTH variable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.