You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2026/06/01 15:05:53 UTC
[PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
sureshanaparti opened a new pull request, #13315:
URL: https://github.com/apache/cloudstack/pull/13315
### Description
This PR deprecates AppCookie (App session) based stickiness type policy for Virtual Router.
Fixes #3253
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Create VPC, network tier(s) and deploy instance on it.
- Acquire public IP and configure load balancing rule.
- On load balancing rule, configure sticky policy with 'AppCookie' method (this should fail with error).
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-6019908103
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-6291404885
> can you live with the current state of this PR?
@DaanHoogland yes, lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-5932065188
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4593900617
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-6034271955
<b>[SF] Trillian test result (tid-17078)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57142 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13315-t17078-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4594336746
I think, a simple solution might be
https://github.com/apache/cloudstack/blob/7308dad19a9a70d33a33a75bea8c51629541e438/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java#L997
throwing an exception after this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-6019995393
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-5492653506
ping @sureshanaparti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-5931131710
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#discussion_r4205081741
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -945,26 +945,8 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {
- String length = null; // optional
- String holdTime = null; // optional
-
- for (final Pair<String, String> paramKV : paramsList) {
- final String key = paramKV.first();
- final String value = paramKV.second();
- if ("length".equalsIgnoreCase(key)) {
- length = value;
- }
- if ("holdtime".equalsIgnoreCase(key)) {
- holdTime = value;
- }
- }
-
- if (length != null && !containsOnlyNumbers(length, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: length is not a number: %s", rule.getLb(), length));
- }
- if (holdTime != null && !containsOnlyNumbers(holdTime, timeEndChar) && !containsOnlyNumbers(holdTime, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: holdtime is not in timeformat: %s", rule.getLb(), holdTime));
- }
+ throw new InvalidParameterValueException(String.format("Failed LB in validation rule: %s Cause: AppCookie based stickiness "
Review Comment:
makes sense, those rules already break the router config today so a clear error on edit is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#discussion_r4199353329
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -945,26 +945,8 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {
- String length = null; // optional
- String holdTime = null; // optional
-
- for (final Pair<String, String> paramKV : paramsList) {
- final String key = paramKV.first();
- final String value = paramKV.second();
- if ("length".equalsIgnoreCase(key)) {
- length = value;
- }
- if ("holdtime".equalsIgnoreCase(key)) {
- holdTime = value;
- }
- }
-
- if (length != null && !containsOnlyNumbers(length, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: length is not a number: %s", rule.getLb(), length));
- }
- if (holdTime != null && !containsOnlyNumbers(holdTime, timeEndChar) && !containsOnlyNumbers(holdTime, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: holdtime is not in timeformat: %s", rule.getLb(), holdTime));
- }
+ throw new InvalidParameterValueException(String.format("Failed LB in validation rule: %s Cause: AppCookie based stickiness "
Review Comment:
appcookie has been deprecated in haproxy from several versions ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4593915539
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4599742431
> I think, a simple solution might be
>
> https://github.com/apache/cloudstack/blob/7308dad19a9a70d33a33a75bea8c51629541e438/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java#L997
>
> throwing an exception after this line
let me check it @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#discussion_r4199306583
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -945,26 +945,8 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {
- String length = null; // optional
- String holdTime = null; // optional
-
- for (final Pair<String, String> paramKV : paramsList) {
- final String key = paramKV.first();
- final String value = paramKV.second();
- if ("length".equalsIgnoreCase(key)) {
- length = value;
- }
- if ("holdtime".equalsIgnoreCase(key)) {
- holdTime = value;
- }
- }
-
- if (length != null && !containsOnlyNumbers(length, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: length is not a number: %s", rule.getLb(), length));
- }
- if (holdTime != null && !containsOnlyNumbers(holdTime, timeEndChar) && !containsOnlyNumbers(holdTime, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: holdtime is not in timeformat: %s", rule.getLb(), holdTime));
- }
+ throw new InvalidParameterValueException(String.format("Failed LB in validation rule: %s Cause: AppCookie based stickiness "
Review Comment:
what happens to lb rules that already have an app cookie policy? looks like editing them will now fail until someone removes the policy
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -945,26 +945,8 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {
- String length = null; // optional
- String holdTime = null; // optional
-
- for (final Pair<String, String> paramKV : paramsList) {
- final String key = paramKV.first();
- final String value = paramKV.second();
- if ("length".equalsIgnoreCase(key)) {
- length = value;
- }
- if ("holdtime".equalsIgnoreCase(key)) {
- holdTime = value;
- }
- }
-
- if (length != null && !containsOnlyNumbers(length, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: length is not a number: %s", rule.getLb(), length));
- }
- if (holdTime != null && !containsOnlyNumbers(holdTime, timeEndChar) && !containsOnlyNumbers(holdTime, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: holdtime is not in timeformat: %s", rule.getLb(), holdTime));
- }
+ throw new InvalidParameterValueException(String.format("Failed LB in validation rule: %s Cause: AppCookie based stickiness "
+ + "(HAProxy 'appsession') is not supported on a Virtual Router, as this directive was removed in HAProxy 1.6", rule.getLb()));
Review Comment:
should we also drop app cookie from the list of methods the router says it supports? right now the ui still offers it and then it fails here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-5931094749
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-6291067351
@Damans227 , can you live with the current state of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reject AppCookie LB stickiness policy on Virtual Router networks [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#discussion_r4325049162
##########
server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java:
##########
@@ -945,26 +945,8 @@ public boolean validateHAProxyLBRule(final LoadBalancingRule rule) {
}
} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {
- String length = null; // optional
- String holdTime = null; // optional
-
- for (final Pair<String, String> paramKV : paramsList) {
- final String key = paramKV.first();
- final String value = paramKV.second();
- if ("length".equalsIgnoreCase(key)) {
- length = value;
- }
- if ("holdtime".equalsIgnoreCase(key)) {
- holdTime = value;
- }
- }
-
- if (length != null && !containsOnlyNumbers(length, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: length is not a number: %s", rule.getLb(), length));
- }
- if (holdTime != null && !containsOnlyNumbers(holdTime, timeEndChar) && !containsOnlyNumbers(holdTime, null)) {
- throw new InvalidParameterValueException(String.format("Failed LB in validation rule id: %s Cause: holdtime is not in timeformat: %s", rule.getLb(), holdTime));
- }
+ throw new InvalidParameterValueException(String.format("Failed LB in validation rule: %s Cause: AppCookie based stickiness "
+ + "(HAProxy 'appsession') is not supported on a Virtual Router, as this directive was removed in HAProxy 1.6", rule.getLb()));
Review Comment:
appcookie has been deprecated by haproxy, but I am not sure if other solutions (network plugins) support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4594642582
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4841662005
@sureshanaparti
is this still WIP ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13315:
URL: https://github.com/apache/cloudstack/pull/13315#issuecomment-4593936265
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13315?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.14%. Comparing base ([`357186d`](https://app.codecov.io/gh/apache/cloudstack/commit/357186d64d0819fc8321b734b69b691ef09e4412?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bfae704`](https://app.codecov.io/gh/apache/cloudstack/commit/bfae704b2b5b07616885938d7828363ad77902e0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on 4.20.
> :exclamation: There is a different number of reports uploaded between BASE (357186d) and HEAD (bfae704). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (357186d) | HEAD (bfae704) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #13315 +/- ##
=============================================
- Coverage 16.26% 4.14% -12.12%
=============================================
Files 5666 405 -5261
Lines 500645 33022 -467623
Branches 60801 5898 -54903
=============================================
- Hits 81429 1370 -80059
+ Misses 410106 31476 -378630
+ Partials 9110 176 -8934
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13315/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.14% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/13315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/13315?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org