[GitHub] [calcite] vlsi commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter
URL: https://github.com/apache/calcite/pull/1030#discussion_r264786709
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
 ##########
 @@ -4292,6 +4293,21 @@ private Sql checkSubQuery(String sql) {
     checkPlanning(program, sql);
   }
 
+  @Test public void testFilterAndProjectWithMultiJoin() throws Exception {
+    final FilterMultiJoinMergeRule filterMultiJoinMergeRule =
+        new FilterMultiJoinMergeRule(LogicalFilter.class, RelFactories.LOGICAL_BUILDER);
+    final ProjectMultiJoinMergeRule projectMultiJoinMergeRule =
+        new ProjectMultiJoinMergeRule(LogicalProject.class, RelFactories.LOGICAL_BUILDER);
 
 Review comment:
   Well, LogicalProject was the default class, so this test does not seem to validate anything new. Does it just duplicate the existing tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services