You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/07/11 00:51:37 UTC
Review Request 60758: Windows: Updated documentation for NTFS long
path support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60758/
-----------------------------------------------------------
Review request for mesos, Joseph Wu and Li Li.
Repository: mesos
Description
-------
The list of individual components was also removed for clarity.
Developers should either install the entire workload (which is confirmed
sufficient), or know their environment well enough to choose specific
components. Furthermore, the list of available components changes
frequently enough that maintaining this list becomes difficult.
Diffs
-----
docs/windows.md d596158b1f5dadddcf28a8675f260924caf33547
Diff: https://reviews.apache.org/r/60758/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 60758: Windows: Updated documentation for NTFS
long path support.
Posted by Joseph Wu <jo...@mesosphere.io>.
Almost didn't notice your message as people typically do not reply to these
emails (except by commenting on the associated review).
The master branch of Mesos now contains support for long paths natively in
Mesos. This means you no longer have to run Mesos in short paths, with
short task names.
On Mon, Jul 10, 2017 at 6:07 PM, Haijiang Chen <ch...@gmail.com>
wrote:
> Does it mean that the Windows Long path will be fixed somewhere in the
> installation?
>
> Thanks,
> Haijiang
> > On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer <
> andrew@schwartzmeyer.com> wrote:
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/60758/
> > -----------------------------------------------------------
> >
> > Review request for mesos, Joseph Wu and Li Li.
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > The list of individual components was also removed for clarity.
> > Developers should either install the entire workload (which is confirmed
> > sufficient), or know their environment well enough to choose specific
> > components. Furthermore, the list of available components changes
> > frequently enough that maintaining this list becomes difficult.
> >
> >
> > Diffs
> > -----
> >
> > docs/windows.md d596158b1f5dadddcf28a8675f260924caf33547
> >
> >
> > Diff: https://reviews.apache.org/r/60758/diff/1/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Andrew Schwartzmeyer
> >
>
>
Re: Review Request 60758: Windows: Updated documentation for NTFS
long path support.
Posted by Haijiang Chen <ch...@gmail.com>.
OK, Thanks Andy. I think I find it from latest source code in github.
-Haijiang
> On 11 Jul 2017, at 11:38 AM, Andrew Schwartzmeyer <an...@schwartzmeyer.com> wrote:
>
> It is all the patches in the series that this patch ended. The start of the chain is here: https://reviews.apache.org/r/60292/ <https://reviews.apache.org/r/60292/>
> Thanks for the interest! It was quite the undertaking to fix this up.
>
> Cheers,
>
> Andy
>
>
> On Mon, Jul 10, 2017, 8:32 PM Haijiang Chen <chjhaijiang@gmail.com <ma...@gmail.com>> wrote:
> Thanks.
> Can you please help to point out which ticket that fixed it? I am interested with code changes as well.
>
> Regards,
> Haijiang
>
>> On 11 Jul 2017, at 9:21 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com <ma...@schwartzmeyer.com>> wrote:
>>
>> It means that it is fixed for Mesos entirely, in code. I rewrote all our use of the Windows APIs to use the Unicode and long path supporting versions exclusively, with a long path helper to pass the correctly formatted paths to the APIs.
>>
>> The only caveat is that tasks which do not support long paths need to have the agent use a short working directory so that the task is run in a short path. But all the Mesos code itself now supports long paths automatically, with zero system configuration :)
>>
>>
>> On Mon, Jul 10, 2017, 6:07 PM Haijiang Chen <chjhaijiang@gmail.com <ma...@gmail.com>> wrote:
>> Does it mean that the Windows Long path will be fixed somewhere in the installation?
>>
>> Thanks,
>> Haijiang
>> > On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com <ma...@schwartzmeyer.com>> wrote:
>> >
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/60758/ <https://reviews.apache.org/r/60758/>
>> > -----------------------------------------------------------
>> >
>> > Review request for mesos, Joseph Wu and Li Li.
>> >
>> >
>> > Repository: mesos
>> >
>> >
>> > Description
>> > -------
>> >
>> > The list of individual components was also removed for clarity.
>> > Developers should either install the entire workload (which is confirmed
>> > sufficient), or know their environment well enough to choose specific
>> > components. Furthermore, the list of available components changes
>> > frequently enough that maintaining this list becomes difficult.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > docs/windows.md <http://windows.md/> d596158b1f5dadddcf28a8675f260924caf33547
>> >
>> >
>> > Diff: https://reviews.apache.org/r/60758/diff/1/ <https://reviews.apache.org/r/60758/diff/1/>
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Andrew Schwartzmeyer
>> >
>
Re: Review Request 60758: Windows: Updated documentation for NTFS
long path support.
Posted by Haijiang Chen <ch...@gmail.com>.
Thanks.
Can you please help to point out which ticket that fixed it? I am interested with code changes as well.
Regards,
Haijiang
> On 11 Jul 2017, at 9:21 AM, Andrew Schwartzmeyer <an...@schwartzmeyer.com> wrote:
>
> It means that it is fixed for Mesos entirely, in code. I rewrote all our use of the Windows APIs to use the Unicode and long path supporting versions exclusively, with a long path helper to pass the correctly formatted paths to the APIs.
>
> The only caveat is that tasks which do not support long paths need to have the agent use a short working directory so that the task is run in a short path. But all the Mesos code itself now supports long paths automatically, with zero system configuration :)
>
>
> On Mon, Jul 10, 2017, 6:07 PM Haijiang Chen <chjhaijiang@gmail.com <ma...@gmail.com>> wrote:
> Does it mean that the Windows Long path will be fixed somewhere in the installation?
>
> Thanks,
> Haijiang
> > On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer <andrew@schwartzmeyer.com <ma...@schwartzmeyer.com>> wrote:
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/60758/ <https://reviews.apache.org/r/60758/>
> > -----------------------------------------------------------
> >
> > Review request for mesos, Joseph Wu and Li Li.
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > The list of individual components was also removed for clarity.
> > Developers should either install the entire workload (which is confirmed
> > sufficient), or know their environment well enough to choose specific
> > components. Furthermore, the list of available components changes
> > frequently enough that maintaining this list becomes difficult.
> >
> >
> > Diffs
> > -----
> >
> > docs/windows.md <http://windows.md/> d596158b1f5dadddcf28a8675f260924caf33547
> >
> >
> > Diff: https://reviews.apache.org/r/60758/diff/1/ <https://reviews.apache.org/r/60758/diff/1/>
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Andrew Schwartzmeyer
> >
Re: Review Request 60758: Windows: Updated documentation for NTFS
long path support.
Posted by Haijiang Chen <ch...@gmail.com>.
Does it mean that the Windows Long path will be fixed somewhere in the installation?
Thanks,
Haijiang
> On 11 Jul 2017, at 8:51 AM, Andrew Schwartzmeyer <an...@schwartzmeyer.com> wrote:
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60758/
> -----------------------------------------------------------
>
> Review request for mesos, Joseph Wu and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The list of individual components was also removed for clarity.
> Developers should either install the entire workload (which is confirmed
> sufficient), or know their environment well enough to choose specific
> components. Furthermore, the list of available components changes
> frequently enough that maintaining this list becomes difficult.
>
>
> Diffs
> -----
>
> docs/windows.md d596158b1f5dadddcf28a8675f260924caf33547
>
>
> Diff: https://reviews.apache.org/r/60758/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
Re: Review Request 60758: Windows: Updated documentation for NTFS
long path support.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60758/#review180149
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 10, 2017, 5:51 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60758/
> -----------------------------------------------------------
>
> (Updated July 10, 2017, 5:51 p.m.)
>
>
> Review request for mesos, Joseph Wu and Li Li.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The list of individual components was also removed for clarity.
> Developers should either install the entire workload (which is confirmed
> sufficient), or know their environment well enough to choose specific
> components. Furthermore, the list of available components changes
> frequently enough that maintaining this list becomes difficult.
>
>
> Diffs
> -----
>
> docs/windows.md d596158b1f5dadddcf28a8675f260924caf33547
>
>
> Diff: https://reviews.apache.org/r/60758/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>