You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2008/06/10 06:34:01 UTC
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Hi Jacques,
I think that we should avoid to add a reference to the applications
from the framework... especially now that we are planning for a
framework only release.
Jacopo
On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Mon Jun 9 15:14:56 2008
> New Revision: 665919
>
> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
> Log:
> A patch from Bruno Busco "ERP header logo should link to home url" (https://issues.apache.org/jira/browse/OFBIZ-1834
> ) - OFBIZ-1834
> I changed the default link from "/" to "/catalog/control/main" which
> makes more sense OOTB
>
> Modified:
> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>
> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> (original)
> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon
> Jun 9 15:14:56 2008
> @@ -69,13 +69,18 @@
> </div>
> <div id="masthead">
> <ul>
> + <#if layoutSettings.headerImageLinkUrl?exists>
> + <#assign logoLinkURL = "$
> {layoutSettings.headerImageLinkUrl}">
> + <#else>
> + <#assign logoLinkURL = "$
> {layoutSettings.commonHeaderImageLinkUrl}">
> + </#if>
> +
> <#if layoutSettings.headerImageUrl?exists>
> - <li class="logo-area"><img alt="$
> {layoutSettings.companyName}" src="<@ofbizContentUrl>$
> {layoutSettings.headerImageUrl}</...@ofbizContentUrl>"/></li>
> + <li class="logo-area"><a href="${logoLinkURL}"><img alt="$
> {layoutSettings.companyName}" src="<@ofbizContentUrl>$
> {layoutSettings.headerImageUrl}</...@ofbizContentUrl>"/></a></li>
> <#else>
> - <li class="logo-area"><img alt="$
> {layoutSettings.companyName}" src="<@ofbizContentUrl>$
> {layoutSettings.commonHeaderImageUrl}</...@ofbizContentUrl>"/></li>
> + <li class="logo-area"><a href="${logoLinkURL}"><img alt="$
> {layoutSettings.companyName}" src="<@ofbizContentUrl>$
> {layoutSettings.commonHeaderImageUrl}</...@ofbizContentUrl>"/></a></li>
> </#if>
> <li class="control-area"<#if
> layoutSettings.headerRightBackgroundUrl?has_content> background="$
> {layoutSettings.headerRightBackgroundUrl}"</#if>>
> - <br />
> <p>
> <#if person?has_content>
> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists} $
> {person.lastName?if_exists} [${userLogin.userLoginId}]
>
> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
> 15:14:56 2008
> @@ -127,6 +127,7 @@
> <set field="layoutSettings.shortcutIcon" value="/
> images/ofbiz.ico" global="true"/>
> <!-- The default (global) logo -->
> <set field="layoutSettings.commonHeaderImageUrl"
> value="/images/ofbiz_logo.jpg" global="true"/>
> + <set
> field="layoutSettings.commonHeaderImageLinkUrl" value="/catalog/
> control/main" global="true"/>
> </actions>
> <widgets>
> <!-- render header -->
>
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
This sounds like a good idea to me. Actually I liked also to point to webtools, but as you said previously it's already available
with the webtools button.
Jacques
From: "Bruno Busco" <br...@gmail.com>
> Of course if this is OK with you I could try to submit a patch for this.
> -Bruno
>
> 2008/6/10 Bruno Busco <br...@gmail.com>:
>
>> The main page of the current application is already always available by
>> clicking on the application tab in the main menu.
>>
>> In my installation I have set up a simple web application mounted to "/"
>> that shows several options to the user. Some of these options are Ofbiz
>> applications, some other point to other stuff not Ofbiz related.
>>
>> From everywhere (Ofbiz and not) it is always possible to go back to this
>> main page to switch from one context to another.
>> This is how I use the logo link in Ofbiz.
>>
>> What do you think of having a simple root webapp already included in the
>> framework?
>> It could be as simple as a single screen that will be pointed to by the
>> logo and could be customized by the user to include other links to whatever
>> needed.
>>
>> -Bruno
>>
>> 2008/6/10 Scott Gray <le...@gmail.com>:
>>
>> Is there a way that we could get it to point to the main page of the
>>> current
>>> application?
>>>
>>> - Scott
>>>
>>> 2008/6/10 Bruno Busco <br...@gmail.com>:
>>>
>>> > Hi,
>>> > if I well understand, installing the framework alone, only the webtools,
>>> > example, exampleext and shark application will be available.
>>> > May be we could change the default logo link to point to the "webtools"
>>> > application so that it is self-referenced.
>>> >
>>> > -Bruno
>>> >
>>> > 2008/6/10 Jacopo Cappellato <ja...@gmail.com>:
>>> >
>>> > > Hi Jacques,
>>> > >
>>> > > I think that we should avoid to add a reference to the applications
>>> from
>>> > > the framework... especially now that we are planning for a framework
>>> only
>>> > > release.
>>> > >
>>> > > Jacopo
>>> > >
>>> > > On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
>>> > >
>>> > > Author: jleroux
>>> > >> Date: Mon Jun 9 15:14:56 2008
>>> > >> New Revision: 665919
>>> > >>
>>> > >> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
>>> > >> Log:
>>> > >> A patch from Bruno Busco "ERP header logo should link to home url" (
>>> > >> https://issues.apache.org/jira/browse/OFBIZ-1834) - OFBIZ-1834
>>> > >> I changed the default link from "/" to "/catalog/control/main" which
>>> > makes
>>> > >> more sense OOTB
>>> > >>
>>> > >> Modified:
>>> > >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>>> > >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> > >>
>>> > >> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>>> > >> URL:
>>> > >>
>>> >
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
>>> > >>
>>> > >>
>>> >
>>> ==============================================================================
>>> > >> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>>> > (original)
>>> > >> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon
>>> Jun
>>> > 9
>>> > >> 15:14:56 2008
>>> > >> @@ -69,13 +69,18 @@
>>> > >> </div>
>>> > >> <div id="masthead">
>>> > >> <ul>
>>> > >> + <#if layoutSettings.headerImageLinkUrl?exists>
>>> > >> + <#assign logoLinkURL =
>>> "${layoutSettings.headerImageLinkUrl}">
>>> > >> + <#else>
>>> > >> + <#assign logoLinkURL =
>>> > >> "${layoutSettings.commonHeaderImageLinkUrl}">
>>> > >> + </#if>
>>> > >> +
>>> > >> <#if layoutSettings.headerImageUrl?exists>
>>> > >> - <li class="logo-area"><img
>>> alt="${layoutSettings.companyName}"
>>> > >>
>>> >
>>> src="<@o...@ofbizContentUrl>"/></li>
>>> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
>>> > >> alt="${layoutSettings.companyName}"
>>> > >>
>>> >
>>> src="<@o...@ofbizContentUrl>"/></a></li>
>>> > >> <#else>
>>> > >> - <li class="logo-area"><img
>>> alt="${layoutSettings.companyName}"
>>> > >>
>>> >
>>> src="<@o...@ofbizContentUrl>"/></li>
>>> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
>>> > >> alt="${layoutSettings.companyName}"
>>> > >>
>>> >
>>> src="<@o...@ofbizContentUrl>"/></a></li>
>>> > >> </#if>
>>> > >> <li class="control-area"<#if
>>> > >> layoutSettings.headerRightBackgroundUrl?has_content>
>>> > >> background="${layoutSettings.headerRightBackgroundUrl}"</#if>>
>>> > >> - <br />
>>> > >> <p>
>>> > >> <#if person?has_content>
>>> > >> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists}
>>> > >> ${person.lastName?if_exists} [${userLogin.userLoginId}]
>>> > >>
>>> > >> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>> > >> URL:
>>> > >>
>>> >
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
>>> > >>
>>> > >>
>>> >
>>> ==============================================================================
>>> > >> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>>> > >> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
>>> > >> 15:14:56 2008
>>> > >> @@ -127,6 +127,7 @@
>>> > >> <set field="layoutSettings.shortcutIcon"
>>> > >> value="/images/ofbiz.ico" global="true"/>
>>> > >> <!-- The default (global) logo -->
>>> > >> <set field="layoutSettings.commonHeaderImageUrl"
>>> > >> value="/images/ofbiz_logo.jpg" global="true"/>
>>> > >> + <set field="layoutSettings.commonHeaderImageLinkUrl"
>>> > >> value="/catalog/control/main" global="true"/>
>>> > >> </actions>
>>> > >> <widgets>
>>> > >> <!-- render header -->
>>> > >>
>>> > >>
>>> > >>
>>> > >
>>> >
>>>
>>
>>
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Bruno Busco <br...@gmail.com>.
Of course if this is OK with you I could try to submit a patch for this.
-Bruno
2008/6/10 Bruno Busco <br...@gmail.com>:
> The main page of the current application is already always available by
> clicking on the application tab in the main menu.
>
> In my installation I have set up a simple web application mounted to "/"
> that shows several options to the user. Some of these options are Ofbiz
> applications, some other point to other stuff not Ofbiz related.
>
> From everywhere (Ofbiz and not) it is always possible to go back to this
> main page to switch from one context to another.
> This is how I use the logo link in Ofbiz.
>
> What do you think of having a simple root webapp already included in the
> framework?
> It could be as simple as a single screen that will be pointed to by the
> logo and could be customized by the user to include other links to whatever
> needed.
>
> -Bruno
>
> 2008/6/10 Scott Gray <le...@gmail.com>:
>
> Is there a way that we could get it to point to the main page of the
>> current
>> application?
>>
>> - Scott
>>
>> 2008/6/10 Bruno Busco <br...@gmail.com>:
>>
>> > Hi,
>> > if I well understand, installing the framework alone, only the webtools,
>> > example, exampleext and shark application will be available.
>> > May be we could change the default logo link to point to the "webtools"
>> > application so that it is self-referenced.
>> >
>> > -Bruno
>> >
>> > 2008/6/10 Jacopo Cappellato <ja...@gmail.com>:
>> >
>> > > Hi Jacques,
>> > >
>> > > I think that we should avoid to add a reference to the applications
>> from
>> > > the framework... especially now that we are planning for a framework
>> only
>> > > release.
>> > >
>> > > Jacopo
>> > >
>> > > On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
>> > >
>> > > Author: jleroux
>> > >> Date: Mon Jun 9 15:14:56 2008
>> > >> New Revision: 665919
>> > >>
>> > >> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
>> > >> Log:
>> > >> A patch from Bruno Busco "ERP header logo should link to home url" (
>> > >> https://issues.apache.org/jira/browse/OFBIZ-1834) - OFBIZ-1834
>> > >> I changed the default link from "/" to "/catalog/control/main" which
>> > makes
>> > >> more sense OOTB
>> > >>
>> > >> Modified:
>> > >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> > >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> > >>
>> > >> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> > >> URL:
>> > >>
>> >
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
>> > >>
>> > >>
>> >
>> ==============================================================================
>> > >> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> > (original)
>> > >> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon
>> Jun
>> > 9
>> > >> 15:14:56 2008
>> > >> @@ -69,13 +69,18 @@
>> > >> </div>
>> > >> <div id="masthead">
>> > >> <ul>
>> > >> + <#if layoutSettings.headerImageLinkUrl?exists>
>> > >> + <#assign logoLinkURL =
>> "${layoutSettings.headerImageLinkUrl}">
>> > >> + <#else>
>> > >> + <#assign logoLinkURL =
>> > >> "${layoutSettings.commonHeaderImageLinkUrl}">
>> > >> + </#if>
>> > >> +
>> > >> <#if layoutSettings.headerImageUrl?exists>
>> > >> - <li class="logo-area"><img
>> alt="${layoutSettings.companyName}"
>> > >>
>> >
>> src="<@o...@ofbizContentUrl>"/></li>
>> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
>> > >> alt="${layoutSettings.companyName}"
>> > >>
>> >
>> src="<@o...@ofbizContentUrl>"/></a></li>
>> > >> <#else>
>> > >> - <li class="logo-area"><img
>> alt="${layoutSettings.companyName}"
>> > >>
>> >
>> src="<@o...@ofbizContentUrl>"/></li>
>> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
>> > >> alt="${layoutSettings.companyName}"
>> > >>
>> >
>> src="<@o...@ofbizContentUrl>"/></a></li>
>> > >> </#if>
>> > >> <li class="control-area"<#if
>> > >> layoutSettings.headerRightBackgroundUrl?has_content>
>> > >> background="${layoutSettings.headerRightBackgroundUrl}"</#if>>
>> > >> - <br />
>> > >> <p>
>> > >> <#if person?has_content>
>> > >> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists}
>> > >> ${person.lastName?if_exists} [${userLogin.userLoginId}]
>> > >>
>> > >> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> > >> URL:
>> > >>
>> >
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
>> > >>
>> > >>
>> >
>> ==============================================================================
>> > >> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>> > >> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
>> > >> 15:14:56 2008
>> > >> @@ -127,6 +127,7 @@
>> > >> <set field="layoutSettings.shortcutIcon"
>> > >> value="/images/ofbiz.ico" global="true"/>
>> > >> <!-- The default (global) logo -->
>> > >> <set field="layoutSettings.commonHeaderImageUrl"
>> > >> value="/images/ofbiz_logo.jpg" global="true"/>
>> > >> + <set field="layoutSettings.commonHeaderImageLinkUrl"
>> > >> value="/catalog/control/main" global="true"/>
>> > >> </actions>
>> > >> <widgets>
>> > >> <!-- render header -->
>> > >>
>> > >>
>> > >>
>> > >
>> >
>>
>
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Bruno Busco <br...@gmail.com>.
The main page of the current application is already always available by
clicking on the application tab in the main menu.
In my installation I have set up a simple web application mounted to "/"
that shows several options to the user. Some of these options are Ofbiz
applications, some other point to other stuff not Ofbiz related.
>From everywhere (Ofbiz and not) it is always possible to go back to this
main page to switch from one context to another.
This is how I use the logo link in Ofbiz.
What do you think of having a simple root webapp already included in the
framework?
It could be as simple as a single screen that will be pointed to by the logo
and could be customized by the user to include other links to whatever
needed.
-Bruno
2008/6/10 Scott Gray <le...@gmail.com>:
> Is there a way that we could get it to point to the main page of the
> current
> application?
>
> - Scott
>
> 2008/6/10 Bruno Busco <br...@gmail.com>:
>
> > Hi,
> > if I well understand, installing the framework alone, only the webtools,
> > example, exampleext and shark application will be available.
> > May be we could change the default logo link to point to the "webtools"
> > application so that it is self-referenced.
> >
> > -Bruno
> >
> > 2008/6/10 Jacopo Cappellato <ja...@gmail.com>:
> >
> > > Hi Jacques,
> > >
> > > I think that we should avoid to add a reference to the applications
> from
> > > the framework... especially now that we are planning for a framework
> only
> > > release.
> > >
> > > Jacopo
> > >
> > > On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
> > >
> > > Author: jleroux
> > >> Date: Mon Jun 9 15:14:56 2008
> > >> New Revision: 665919
> > >>
> > >> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
> > >> Log:
> > >> A patch from Bruno Busco "ERP header logo should link to home url" (
> > >> https://issues.apache.org/jira/browse/OFBIZ-1834) - OFBIZ-1834
> > >> I changed the default link from "/" to "/catalog/control/main" which
> > makes
> > >> more sense OOTB
> > >>
> > >> Modified:
> > >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> > >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
> > >>
> > >> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
> > >>
> > >>
> >
> ==============================================================================
> > >> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> > (original)
> > >> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon Jun
> > 9
> > >> 15:14:56 2008
> > >> @@ -69,13 +69,18 @@
> > >> </div>
> > >> <div id="masthead">
> > >> <ul>
> > >> + <#if layoutSettings.headerImageLinkUrl?exists>
> > >> + <#assign logoLinkURL =
> "${layoutSettings.headerImageLinkUrl}">
> > >> + <#else>
> > >> + <#assign logoLinkURL =
> > >> "${layoutSettings.commonHeaderImageLinkUrl}">
> > >> + </#if>
> > >> +
> > >> <#if layoutSettings.headerImageUrl?exists>
> > >> - <li class="logo-area"><img
> alt="${layoutSettings.companyName}"
> > >>
> >
> src="<@o...@ofbizContentUrl>"/></li>
> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
> > >> alt="${layoutSettings.companyName}"
> > >>
> >
> src="<@o...@ofbizContentUrl>"/></a></li>
> > >> <#else>
> > >> - <li class="logo-area"><img
> alt="${layoutSettings.companyName}"
> > >>
> >
> src="<@o...@ofbizContentUrl>"/></li>
> > >> + <li class="logo-area"><a href="${logoLinkURL}"><img
> > >> alt="${layoutSettings.companyName}"
> > >>
> >
> src="<@o...@ofbizContentUrl>"/></a></li>
> > >> </#if>
> > >> <li class="control-area"<#if
> > >> layoutSettings.headerRightBackgroundUrl?has_content>
> > >> background="${layoutSettings.headerRightBackgroundUrl}"</#if>>
> > >> - <br />
> > >> <p>
> > >> <#if person?has_content>
> > >> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists}
> > >> ${person.lastName?if_exists} [${userLogin.userLoginId}]
> > >>
> > >> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
> > >> URL:
> > >>
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
> > >>
> > >>
> >
> ==============================================================================
> > >> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
> > >> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
> > >> 15:14:56 2008
> > >> @@ -127,6 +127,7 @@
> > >> <set field="layoutSettings.shortcutIcon"
> > >> value="/images/ofbiz.ico" global="true"/>
> > >> <!-- The default (global) logo -->
> > >> <set field="layoutSettings.commonHeaderImageUrl"
> > >> value="/images/ofbiz_logo.jpg" global="true"/>
> > >> + <set field="layoutSettings.commonHeaderImageLinkUrl"
> > >> value="/catalog/control/main" global="true"/>
> > >> </actions>
> > >> <widgets>
> > >> <!-- render header -->
> > >>
> > >>
> > >>
> > >
> >
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Scott Gray <le...@gmail.com>.
Is there a way that we could get it to point to the main page of the current
application?
- Scott
2008/6/10 Bruno Busco <br...@gmail.com>:
> Hi,
> if I well understand, installing the framework alone, only the webtools,
> example, exampleext and shark application will be available.
> May be we could change the default logo link to point to the "webtools"
> application so that it is self-referenced.
>
> -Bruno
>
> 2008/6/10 Jacopo Cappellato <ja...@gmail.com>:
>
> > Hi Jacques,
> >
> > I think that we should avoid to add a reference to the applications from
> > the framework... especially now that we are planning for a framework only
> > release.
> >
> > Jacopo
> >
> > On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
> >
> > Author: jleroux
> >> Date: Mon Jun 9 15:14:56 2008
> >> New Revision: 665919
> >>
> >> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
> >> Log:
> >> A patch from Bruno Busco "ERP header logo should link to home url" (
> >> https://issues.apache.org/jira/browse/OFBIZ-1834) - OFBIZ-1834
> >> I changed the default link from "/" to "/catalog/control/main" which
> makes
> >> more sense OOTB
> >>
> >> Modified:
> >> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> >> ofbiz/trunk/framework/common/widget/CommonScreens.xml
> >>
> >> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
> >>
> >>
> ==============================================================================
> >> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl
> (original)
> >> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon Jun
> 9
> >> 15:14:56 2008
> >> @@ -69,13 +69,18 @@
> >> </div>
> >> <div id="masthead">
> >> <ul>
> >> + <#if layoutSettings.headerImageLinkUrl?exists>
> >> + <#assign logoLinkURL = "${layoutSettings.headerImageLinkUrl}">
> >> + <#else>
> >> + <#assign logoLinkURL =
> >> "${layoutSettings.commonHeaderImageLinkUrl}">
> >> + </#if>
> >> +
> >> <#if layoutSettings.headerImageUrl?exists>
> >> - <li class="logo-area"><img alt="${layoutSettings.companyName}"
> >>
> src="<@o...@ofbizContentUrl>"/></li>
> >> + <li class="logo-area"><a href="${logoLinkURL}"><img
> >> alt="${layoutSettings.companyName}"
> >>
> src="<@o...@ofbizContentUrl>"/></a></li>
> >> <#else>
> >> - <li class="logo-area"><img alt="${layoutSettings.companyName}"
> >>
> src="<@o...@ofbizContentUrl>"/></li>
> >> + <li class="logo-area"><a href="${logoLinkURL}"><img
> >> alt="${layoutSettings.companyName}"
> >>
> src="<@o...@ofbizContentUrl>"/></a></li>
> >> </#if>
> >> <li class="control-area"<#if
> >> layoutSettings.headerRightBackgroundUrl?has_content>
> >> background="${layoutSettings.headerRightBackgroundUrl}"</#if>>
> >> - <br />
> >> <p>
> >> <#if person?has_content>
> >> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists}
> >> ${person.lastName?if_exists} [${userLogin.userLoginId}]
> >>
> >> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
> >>
> >>
> ==============================================================================
> >> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
> >> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
> >> 15:14:56 2008
> >> @@ -127,6 +127,7 @@
> >> <set field="layoutSettings.shortcutIcon"
> >> value="/images/ofbiz.ico" global="true"/>
> >> <!-- The default (global) logo -->
> >> <set field="layoutSettings.commonHeaderImageUrl"
> >> value="/images/ofbiz_logo.jpg" global="true"/>
> >> + <set field="layoutSettings.commonHeaderImageLinkUrl"
> >> value="/catalog/control/main" global="true"/>
> >> </actions>
> >> <widgets>
> >> <!-- render header -->
> >>
> >>
> >>
> >
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Bruno Busco <br...@gmail.com>.
Hi,
if I well understand, installing the framework alone, only the webtools,
example, exampleext and shark application will be available.
May be we could change the default logo link to point to the "webtools"
application so that it is self-referenced.
-Bruno
2008/6/10 Jacopo Cappellato <ja...@gmail.com>:
> Hi Jacques,
>
> I think that we should avoid to add a reference to the applications from
> the framework... especially now that we are planning for a framework only
> release.
>
> Jacopo
>
> On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
>
> Author: jleroux
>> Date: Mon Jun 9 15:14:56 2008
>> New Revision: 665919
>>
>> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
>> Log:
>> A patch from Bruno Busco "ERP header logo should link to home url" (
>> https://issues.apache.org/jira/browse/OFBIZ-1834) - OFBIZ-1834
>> I changed the default link from "/" to "/catalog/control/main" which makes
>> more sense OOTB
>>
>> Modified:
>> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>
>> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl (original)
>> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon Jun 9
>> 15:14:56 2008
>> @@ -69,13 +69,18 @@
>> </div>
>> <div id="masthead">
>> <ul>
>> + <#if layoutSettings.headerImageLinkUrl?exists>
>> + <#assign logoLinkURL = "${layoutSettings.headerImageLinkUrl}">
>> + <#else>
>> + <#assign logoLinkURL =
>> "${layoutSettings.commonHeaderImageLinkUrl}">
>> + </#if>
>> +
>> <#if layoutSettings.headerImageUrl?exists>
>> - <li class="logo-area"><img alt="${layoutSettings.companyName}"
>> src="<@o...@ofbizContentUrl>"/></li>
>> + <li class="logo-area"><a href="${logoLinkURL}"><img
>> alt="${layoutSettings.companyName}"
>> src="<@o...@ofbizContentUrl>"/></a></li>
>> <#else>
>> - <li class="logo-area"><img alt="${layoutSettings.companyName}"
>> src="<@o...@ofbizContentUrl>"/></li>
>> + <li class="logo-area"><a href="${logoLinkURL}"><img
>> alt="${layoutSettings.companyName}"
>> src="<@o...@ofbizContentUrl>"/></a></li>
>> </#if>
>> <li class="control-area"<#if
>> layoutSettings.headerRightBackgroundUrl?has_content>
>> background="${layoutSettings.headerRightBackgroundUrl}"</#if>>
>> - <br />
>> <p>
>> <#if person?has_content>
>> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists}
>> ${person.lastName?if_exists} [${userLogin.userLoginId}]
>>
>> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9
>> 15:14:56 2008
>> @@ -127,6 +127,7 @@
>> <set field="layoutSettings.shortcutIcon"
>> value="/images/ofbiz.ico" global="true"/>
>> <!-- The default (global) logo -->
>> <set field="layoutSettings.commonHeaderImageUrl"
>> value="/images/ofbiz_logo.jpg" global="true"/>
>> + <set field="layoutSettings.commonHeaderImageLinkUrl"
>> value="/catalog/control/main" global="true"/>
>> </actions>
>> <widgets>
>> <!-- render header -->
>>
>>
>>
>
Re: svn commit: r665919 - in /ofbiz/trunk/framework/common: webcommon/includes/header.ftl widget/CommonScreens.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Jacopo,
I liked the idea to come back from where we start. But did no thought about this issue. I find Bruno's new suggestions useful.
Jacques
From: "Jacopo Cappellato" <ja...@gmail.com>
> Hi Jacques,
>
> I think that we should avoid to add a reference to the applications from the framework... especially now that we are planning for
> a framework only release.
>
> Jacopo
>
> On Jun 10, 2008, at 12:14 AM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Mon Jun 9 15:14:56 2008
>> New Revision: 665919
>>
>> URL: http://svn.apache.org/viewvc?rev=665919&view=rev
>> Log:
>> A patch from Bruno Busco "ERP header logo should link to home url" (https://issues.apache.org/jira/browse/OFBIZ-1834 ) -
>> OFBIZ-1834
>> I changed the default link from "/" to "/catalog/control/main" which makes more sense OOTB
>>
>> Modified:
>> ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> ofbiz/trunk/framework/common/widget/CommonScreens.xml
>>
>> Modified: ofbiz/trunk/framework/common/webcommon/includes/header.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/header.ftl?rev=665919&r1=665918&r2=665919&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/framework/common/webcommon/includes/header.ftl (original)
>> +++ ofbiz/trunk/framework/common/webcommon/includes/header.ftl Mon Jun 9 15:14:56 2008
>> @@ -69,13 +69,18 @@
>> </div>
>> <div id="masthead">
>> <ul>
>> + <#if layoutSettings.headerImageLinkUrl?exists>
>> + <#assign logoLinkURL = "$ {layoutSettings.headerImageLinkUrl}">
>> + <#else>
>> + <#assign logoLinkURL = "$ {layoutSettings.commonHeaderImageLinkUrl}">
>> + </#if>
>> +
>> <#if layoutSettings.headerImageUrl?exists>
>> - <li class="logo-area"><img alt="$ {layoutSettings.companyName}" src="<@ofbizContentUrl>$
>> {layoutSettings.headerImageUrl}</...@ofbizContentUrl>"/></li>
>> + <li class="logo-area"><a href="${logoLinkURL}"><img alt="$ {layoutSettings.companyName}" src="<@ofbizContentUrl>$
>> {layoutSettings.headerImageUrl}</...@ofbizContentUrl>"/></a></li>
>> <#else>
>> - <li class="logo-area"><img alt="$ {layoutSettings.companyName}" src="<@ofbizContentUrl>$
>> {layoutSettings.commonHeaderImageUrl}</...@ofbizContentUrl>"/></li>
>> + <li class="logo-area"><a href="${logoLinkURL}"><img alt="$ {layoutSettings.companyName}" src="<@ofbizContentUrl>$
>> {layoutSettings.commonHeaderImageUrl}</...@ofbizContentUrl>"/></a></li>
>> </#if>
>> <li class="control-area"<#if layoutSettings.headerRightBackgroundUrl?has_content> background="$
>> {layoutSettings.headerRightBackgroundUrl}"</#if>>
>> - <br />
>> <p>
>> <#if person?has_content>
>> ${uiLabelMap.CommonWelcome} ${person.firstName?if_exists} $ {person.lastName?if_exists} [${userLogin.userLoginId}]
>>
>> Modified: ofbiz/trunk/framework/common/widget/CommonScreens.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/widget/CommonScreens.xml?rev=665919&r1=665918&r2=665919&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/framework/common/widget/CommonScreens.xml (original)
>> +++ ofbiz/trunk/framework/common/widget/CommonScreens.xml Mon Jun 9 15:14:56 2008
>> @@ -127,6 +127,7 @@
>> <set field="layoutSettings.shortcutIcon" value="/ images/ofbiz.ico" global="true"/>
>> <!-- The default (global) logo -->
>> <set field="layoutSettings.commonHeaderImageUrl" value="/images/ofbiz_logo.jpg" global="true"/>
>> + <set field="layoutSettings.commonHeaderImageLinkUrl" value="/catalog/ control/main" global="true"/>
>> </actions>
>> <widgets>
>> <!-- render header -->
>>
>>
>