You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/04 18:15:45 UTC
[jira] Created: (HARMONY-5570) [classlib][pack200]
LineNumberTableAttribute being computed incorrectly
[classlib][pack200] LineNumberTableAttribute being computed incorrectly
-----------------------------------------------------------------------
Key: HARMONY-5570
URL: https://issues.apache.org/jira/browse/HARMONY-5570
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: Latest Pack200
Reporter: Andrew Cornwall
In the latest Pack200 code, the LineNumberTable attribute is being calculated incorrectly. It appears to be right for a single class at a time, but when multiple classes are being unpacked the line_number values go strange.
To reproduce, unpack the attached mypack.pack and look at the LineNumberTable attribute for CPString.<init>. The LineNumberTable in the Harmony version is:
attribute LineNumberTable {
attribute_name_index = #88 // "LineNumberTable"
attribute_length = 18
line_number_table_length = 4
line_number_table {
// start_pc line_number
0 2323
7 2324
14 2325
35 2327
}
}
whereas the LineNumberTable should be:
attribute LineNumberTable {
attribute_name_index = #9 // "LineNumberTable"
attribute_length = 18
line_number_table_length = 4
line_number_table {
// start_pc line_number
0 27
7 28
14 29
35 31
}
If I had to guess, I'd bet the initial value is computed incorrectly, and subsequent deltas inherit the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5570) [classlib][pack200]
LineNumberTableAttribute being computed incorrectly
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5570:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] LineNumberTableAttribute being computed incorrectly
> -----------------------------------------------------------------------
>
> Key: HARMONY-5570
> URL: https://issues.apache.org/jira/browse/HARMONY-5570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Latest Pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: mypack.jar, mypack.pack
>
>
> In the latest Pack200 code, the LineNumberTable attribute is being calculated incorrectly. It appears to be right for a single class at a time, but when multiple classes are being unpacked the line_number values go strange.
> To reproduce, unpack the attached mypack.pack and look at the LineNumberTable attribute for CPString.<init>. The LineNumberTable in the Harmony version is:
> attribute LineNumberTable {
> attribute_name_index = #88 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 2323
> 7 2324
> 14 2325
> 35 2327
> }
> }
> whereas the LineNumberTable should be:
> attribute LineNumberTable {
> attribute_name_index = #9 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 27
> 7 28
> 14 29
> 35 31
> }
> If I had to guess, I'd bet the initial value is computed incorrectly, and subsequent deltas inherit the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5570) [classlib][pack200]
LineNumberTableAttribute being computed incorrectly
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall closed HARMONY-5570.
------------------------------------
Thanks, this resolves the issue. Closing.
> [classlib][pack200] LineNumberTableAttribute being computed incorrectly
> -----------------------------------------------------------------------
>
> Key: HARMONY-5570
> URL: https://issues.apache.org/jira/browse/HARMONY-5570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Latest Pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: mypack.jar, mypack.pack
>
>
> In the latest Pack200 code, the LineNumberTable attribute is being calculated incorrectly. It appears to be right for a single class at a time, but when multiple classes are being unpacked the line_number values go strange.
> To reproduce, unpack the attached mypack.pack and look at the LineNumberTable attribute for CPString.<init>. The LineNumberTable in the Harmony version is:
> attribute LineNumberTable {
> attribute_name_index = #88 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 2323
> 7 2324
> 14 2325
> 35 2327
> }
> }
> whereas the LineNumberTable should be:
> attribute LineNumberTable {
> attribute_name_index = #9 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 27
> 7 28
> 14 29
> 35 31
> }
> If I had to guess, I'd bet the initial value is computed incorrectly, and subsequent deltas inherit the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5570) [classlib][pack200]
LineNumberTableAttribute being computed incorrectly
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5570:
-------------------------------------
Attachment: mypack.pack
mypack.jar
Attached mypack.pack (test case) and mypack.jar (original JAR file used to build .pack)
> [classlib][pack200] LineNumberTableAttribute being computed incorrectly
> -----------------------------------------------------------------------
>
> Key: HARMONY-5570
> URL: https://issues.apache.org/jira/browse/HARMONY-5570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Latest Pack200
> Reporter: Andrew Cornwall
> Attachments: mypack.jar, mypack.pack
>
>
> In the latest Pack200 code, the LineNumberTable attribute is being calculated incorrectly. It appears to be right for a single class at a time, but when multiple classes are being unpacked the line_number values go strange.
> To reproduce, unpack the attached mypack.pack and look at the LineNumberTable attribute for CPString.<init>. The LineNumberTable in the Harmony version is:
> attribute LineNumberTable {
> attribute_name_index = #88 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 2323
> 7 2324
> 14 2325
> 35 2327
> }
> }
> whereas the LineNumberTable should be:
> attribute LineNumberTable {
> attribute_name_index = #9 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 27
> 7 28
> 14 29
> 35 31
> }
> If I had to guess, I'd bet the initial value is computed incorrectly, and subsequent deltas inherit the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5570) [classlib][pack200]
LineNumberTableAttribute being computed incorrectly
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5570.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Checked in a fix at r633849. Andrew - please check that this fully resolves the issue.
> [classlib][pack200] LineNumberTableAttribute being computed incorrectly
> -----------------------------------------------------------------------
>
> Key: HARMONY-5570
> URL: https://issues.apache.org/jira/browse/HARMONY-5570
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: Latest Pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: mypack.jar, mypack.pack
>
>
> In the latest Pack200 code, the LineNumberTable attribute is being calculated incorrectly. It appears to be right for a single class at a time, but when multiple classes are being unpacked the line_number values go strange.
> To reproduce, unpack the attached mypack.pack and look at the LineNumberTable attribute for CPString.<init>. The LineNumberTable in the Harmony version is:
> attribute LineNumberTable {
> attribute_name_index = #88 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 2323
> 7 2324
> 14 2325
> 35 2327
> }
> }
> whereas the LineNumberTable should be:
> attribute LineNumberTable {
> attribute_name_index = #9 // "LineNumberTable"
> attribute_length = 18
> line_number_table_length = 4
> line_number_table {
> // start_pc line_number
> 0 27
> 7 28
> 14 29
> 35 31
> }
> If I had to guess, I'd bet the initial value is computed incorrectly, and subsequent deltas inherit the error.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.