You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/10 11:19:59 UTC

[GitHub] [arrow] zhztheplayer commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-641936183


   Hi @fsaintjacques, @emkornfield  it would be much appreciated if you would like to continue reviewing this, here is a list for modifications since latest review comment:
   
   - code rebase
   - removed SingleFileDataset(Factory)
   - added API `FileSystemDatasetFactory::Make(
       std::string uri, std::shared_ptr<FileFormat> format,
       FileSystemFactoryOptions options)` 
   - other minor changes (see commits after 6f4a914)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org