[jira] [Commented] (HADOOP-7808) Port token service changes from 205

["Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166454#comment-13166454 ] 

Suresh Srinivas commented on HADOOP-7808:
-----------------------------------------

Comments:
# General:
#* Where @InterfaceAudience.Private is used, you do not need Unstable
#* Add @VisibleForTesting instead of Private & Unstable annotation to SecurityUtil#setTokenServiceUseIp, NetUtils#setHostResolver(). This is true for other methods that may be using Private, Unstable annotation instead of @VisibleForTesting
# NetUtils.java
#* "// this was added in 205, but poorly named" Is this comment needed? Also makeSocketAddr needed?
#* protected static class can be just static class (that is package private). Same is true for other protected interfaces in the class
#* Make canonicalizedHostCache final
# FileSystem.java
#* Change "* * Get " to "* Get"
#* I did not thoroughly review the changes in this file - I am assuming the code is identical to 205. Please confirm.
# HADOOP_SECURITY_TOKEN_SERVICE_USE_IP "security.token.service.use_ip" - is this missing "hadoop." compared to 205? Is this not backward incompatible?
# I did not check FileSystem.java and tests thoroughly. I am assuming the code is identical to 205. Please confirm.

                
> Port token service changes from 205
> -----------------------------------
>
>                 Key: HADOOP-7808
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7808
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs, security
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-7808-1.patch, HADOOP-7808-2.patch, HADOOP-7808.patch
>
>
> Need to merge the 205 token bug fixes and the feature to enable hostname-based tokens.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira