[GitHub] [spark] cloud-fan edited a comment on issue #26811: [SPARK-29600][SQL] array_contains built in function is not backward compatible in 3.0

[GitBox <gi...@apache.org>]

cloud-fan edited a comment on issue #26811: [SPARK-29600][SQL] array_contains built in function is not backward compatible in 3.0
URL: https://github.com/apache/spark/pull/26811#issuecomment-564920782
 
 
   let me make my review comment clear: I don't think we should simply call `findWiderTypeForTwo`, which does much more than decimal type coercion.
   
   After taking a look at `DecimalPrecision`, I found we have the same decimal type coercion implemented in `TypeCoercion` as well: `findWiderTypeForDecimal`.
   
   Now we can have a simple fix: replace `findTightestCommonType` with `findWiderTypeWithoutStringPromotionForTwo`, which simply calls `findTightestCommonType` and then `findWiderTypeForDecimal`, and also deals with complex types as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org