[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #123: provide unified query resource control interface

[GitBox <gi...@apache.org>]

jt2594838 commented on a change in pull request #123: provide unified query resource control interface
URL: https://github.com/apache/incubator-iotdb/pull/123#discussion_r271148954
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/query/control/QueryResourceManager.java
 ##########
 @@ -34,13 +37,17 @@
 
 /**
  * <p>
- * Singleton pattern, to manage all query tokens. Each jdbc query request can query multiple series,
- * in the processing of querying different device id, the <code>FileNodeManager.getInstance().
- * beginQuery</code> and <code>FileNodeManager.getInstance().endQueryForGivenJob</code> must be invoked in the
- * beginning and ending of jdbc request.
+ * QueryResourceManager manages resource (file streams) used by each query job, and assign Ids to the jobs.
+ * During the life cycle of a query, the following methods must be called in strict order:
+ * 1. assignJobId - get an Id for the new job.
+ * 2. beginQueryOfGivenQueryPaths - remind FileNodeManager that some files are being used
+ * 3. (if using filter)beginQueryOfGivenExpression
 
 Review comment:
   Both, as you can see, there is no condition on the second step.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services