You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "hudeqi (via GitHub)" <gi...@apache.org> on 2023/04/14 10:29:25 UTC
[GitHub] [kafka] hudeqi opened a new pull request, #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
hudeqi opened a new pull request, #13571:
URL: https://github.com/apache/kafka/pull/13571
Currently, there are three indicators for measuring topic dimensions: MessagesInPerSec, BytesInPerSec, and BytesOutPerSec, but there are two problems:
1. It is difficult to intuitively reflect the problem of topic partition traffic inclination through these indicators, and it is impossible to clearly see which partition has the largest traffic and the traffic situation of each partition.
2. For the sudden increase in topic traffic, the indicators of the partition dimension can provide guidance on whether to expand the partition and roughly how many partitions to expand.
The added three partition dimension metrics have passed the unit test in MetricsTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1518511048
> Does this PR need a KIP process? Anyone take a look?
Metrics are part of the public api. Changing or adding metrics require a KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1520050947
@hudeqi Thanks for the PR and KIP. The KIP has to be discussed and voted by the community. See the process section in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
Also a previous KIP had similar goals: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=148642648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1512389741
Does this PR need a KIP process? Anyone take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1518936086
> > Does this PR need a KIP process? Anyone take a look?
>
> Metrics are part of the public api. Changing or adding metrics require a KIP.
Hi, thanks your reply, the KIP is [here](https://cwiki.apache.org/confluence/x/LQs0Dw).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi closed pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi closed pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
URL: https://github.com/apache/kafka/pull/13571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "hudeqi (via GitHub)" <gi...@apache.org>.
hudeqi commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1520098448
> @hudeqi Thanks for the PR and KIP. The KIP has to be discussed and voted by the community. See the process section in https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals
>
> Also a previous KIP had similar goals: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=148642648
Sorry, I didn't notice that KIP mentioned this issue before. I read the previous KIP discussion, and it seems that there is no conclusion, so how to deal with this issue next?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] github-actions[bot] commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13571:
URL: https://github.com/apache/kafka/pull/13571#issuecomment-1647146954
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurrs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org