You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/04/06 15:12:16 UTC
[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...
GitHub user geomacy opened a pull request:
https://github.com/apache/brooklyn-client/pull/16
Use Go 1.6 vendoring instead of Godep.
Uses current version of dependencies, just moving them to the vendor directory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/geomacy/brooklyn-client vendoring
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-client/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 3fa12d48772eb3d86825e12b44d10806adb1c37c
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date: 2016-04-06T13:03:18Z
Use Go 1.6 vendoring instead of Godep.
Uses current version of dependencies, just moving them to the vendor directory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/brooklyn-client/pull/16#issuecomment-206434349
LGTM :: Warnings are gone :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the pull request:
https://github.com/apache/brooklyn-client/pull/16#issuecomment-206431803
builds and LGTM too :thumbsup:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-client/pull/16#issuecomment-206419694
Looks good and builds cleanly. Even the warning is gone now. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-client/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---