You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "madilrob (via GitHub)" <gi...@apache.org> on 2026/09/25 21:52:24 UTC
[PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
madilrob opened a new pull request, #257:
URL: https://github.com/apache/flink-connector-aws/pull/257
## Purpose of the change
Enable the `apache-flink-connector-aws` python package to be published to PyPi, allowing PyFlink users to install the connectors via `pip install apache-flink-connector-aws`.
Package successfully built and uploaded to TestPyPI: https://test.pypi.org/project/apache-flink-connector-aws/6.1.dev0/
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
- The existing flink-python module tests validate the Python wrapper functionality
- The python_test job in CI runs linting (flake8, mypy) and integration tests
- Package build was manually verified with python -m build and twine check dist/*
- TestPyPI upload and installation were manually verified
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ X] New feature has been introduced
- If yes, how is this documented? Updated kinesis.md with Python installation instructions and code examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "Samrat002 (via GitHub)" <gi...@apache.org>.
Samrat002 commented on PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#issuecomment-6161988250
Thank you for the effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#issuecomment-6161998958
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "madilrob (via GitHub)" <gi...@apache.org>.
madilrob commented on code in PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#discussion_r4169601506
##########
docs/content/docs/connectors/datastream/kinesis.md:
##########
@@ -99,6 +115,36 @@ val kinesisEvents = env.fromSource(kdsSource, WatermarkStrategy.forMonotonousTim
.uid("custom-uid")
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+from pyflink.common import Configuration, WatermarkStrategy, Duration
+from pyflink.common.serialization import SimpleStringSchema
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import KinesisStreamsSource, KinesisShardAssigner
Review Comment:
Yes you're right. Addressing these comments in a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#issuecomment-5840176164
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "mateczagany (via GitHub)" <gi...@apache.org>.
mateczagany commented on code in PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#discussion_r4165676325
##########
docs/content/docs/connectors/datastream/kinesis.md:
##########
@@ -99,6 +115,36 @@ val kinesisEvents = env.fromSource(kdsSource, WatermarkStrategy.forMonotonousTim
.uid("custom-uid")
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+from pyflink.common import Configuration, WatermarkStrategy, Duration
+from pyflink.common.serialization import SimpleStringSchema
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import KinesisStreamsSource, KinesisShardAssigner
+
+# Configure the KinesisStreamsSource
+source_config = Configuration()
+# source_config.set_string("flink.stream.initpos", "TRIM_HORIZON") # Optional, default is LATEST
Review Comment:
If I'm not mistaken, it's `source.init.position` instead of `flink.stream.initpos`
##########
docs/content/docs/connectors/datastream/kinesis.md:
##########
@@ -99,6 +115,36 @@ val kinesisEvents = env.fromSource(kdsSource, WatermarkStrategy.forMonotonousTim
.uid("custom-uid")
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+from pyflink.common import Configuration, WatermarkStrategy, Duration
+from pyflink.common.serialization import SimpleStringSchema
+from pyflink.datastream import StreamExecutionEnvironment
+from pyflink.datastream.connectors import KinesisStreamsSource, KinesisShardAssigner
Review Comment:
Aren't these imported from `pyflink.datastream.connectors.kinesis` instead?
##########
.github/workflows/publish-python.yml:
##########
@@ -0,0 +1,122 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Python Package to PyPI
+
+on:
+ release:
+ types: [published]
+ workflow_dispatch:
+ inputs:
+ dry_run:
+ description: 'Dry run (build but do not publish)'
Review Comment:
I think the description and name `dry_run` is a bit misleading, as it will still publish the package, just to TestPyPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "madilrob (via GitHub)" <gi...@apache.org>.
madilrob commented on code in PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257#discussion_r4169609545
##########
.github/workflows/publish-python.yml:
##########
@@ -0,0 +1,122 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Publish Python Package to PyPI
+
+on:
+ release:
+ types: [published]
+ workflow_dispatch:
+ inputs:
+ dry_run:
+ description: 'Dry run (build but do not publish)'
Review Comment:
I agree. I changed it so the intent is clear and you're choosing where to publish. Options: testpypi and pypi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40808] Add PyPI publishing support for apache-flink-connector-aws [flink-connector-aws]
Posted by "Samrat002 (via GitHub)" <gi...@apache.org>.
Samrat002 merged PR #257:
URL: https://github.com/apache/flink-connector-aws/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org