You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2017/02/11 23:04:46 UTC
[DISCUSS] Release Apache Flex SDK 4.16 RC2
Hi,
Please discuss the release candidate here and not in the vote thread.
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/16/17, 12:44 AM, "justin@classsoftware.com"
<ju...@classsoftware.com> wrote:
>Hi,
>
>Looks like the issue is this, this has been running for 9+ hours and
>should probably be killed [1]
>
>May be a good idea to limit the time that job runs,it's usually fairly
>quick right?
Sure, go ahead and do it. But some jobs do take a while on that server.
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by ju...@classsoftware.com.
Hi,
Looks like the issue is this, this has been running for 9+ hours and should probably be killed [1]
May be a good idea to limit the time that job runs,it's usually fairly quick right?
Thanks,
Justin
1. http://apacheflexbuild.cloudapp.net:8080/job/MD5Checker/15255/
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/16/17, 12:32 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>It looks like it hasn’t done a build yet and it still waiting on a
>pending slot. [1]
OK, build finished and I ran the approval script on it and checked asdoc.
I'm good to go.
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Where did you look?
I compiled the SDK from the release branch (using the build/build_release.sh script) on my local machine and looked at the artefacts it produced.
> I just looked at apacheflexbuilds and AFAICT it has
> not built a build with your changes.
It looks like it hasn’t done a build yet and it still waiting on a pending slot. [1]
Thanks,
Justin
1. http://apacheflexbuild.cloudapp.net:8080/job/flex-sdk_release-candidate/
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 5:57 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>I looked at a build from the saxon changes I just made and can confirm:
>- saxon notice files are in source release
>- saxon9.jar is in the binary
>- asdocs works
Where did you look? I just looked at apacheflexbuilds and AFAICT it has
not built a build with your changes. So now I am truly puzzled as to how
it worked for you and how the last RC source package built for you. What
is different about your configuration?
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> If you run it with -Drc=2 it would grab RC2 from dist.apache.org <http://dist.apache.org/>. Also
> you can manually download the artifacts and run the main-no-download
> target.
>
> If we improve it, instead of complaining about it, it will save everyone
> in the community time and maybe encourage more folks to be RMs.
There's no documentation for it right? Perhaps documenting what all the options are and how to use on the wiki would be a good start?
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 5:57 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> I'm not saying the ApprovalScript is a requirement, I'm saying that that
>> is what I use, so you can know up front what tests I am going to run so
>> you can potentially save all of us time by making sure it passes those
>> tests before offering another RC.
>
>The ApprovalScript generally fails to me as it timeouts on downloading
>the artifacts or takes hours to do so. It also doesn’t test the actual RC
>just what’s built on the CI machine which in theory should be the same
>but that has bitten me a few times due to differences what’s in
>.git_ignore and similar. If it could test a RC I just made on my machine
>without downloading anything I would probably use it. It also picks up
>environment variables so I was never sure exactly what it was testing
>it's all a bit too black box for me. It runs rat with exclusions which
>from my experience in the incubator where most issues show up. It
>probably works better in the US (where the server is located?) or for
>people who have better bandwidth connections.
If you run it with -Drc=2 it would grab RC2 from dist.apache.org. Also
you can manually download the artifacts and run the main-no-download
target.
If we improve it, instead of complaining about it, it will save everyone
in the community time and maybe encourage more folks to be RMs.
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I'm not saying the ApprovalScript is a requirement, I'm saying that that
> is what I use, so you can know up front what tests I am going to run so
> you can potentially save all of us time by making sure it passes those
> tests before offering another RC.
The ApprovalScript generally fails to me as it timeouts on downloading the artifacts or takes hours to do so. It also doesn’t test the actual RC just what’s built on the CI machine which in theory should be the same but that has bitten me a few times due to differences what’s in .git_ignore and similar. If it could test a RC I just made on my machine without downloading anything I would probably use it. It also picks up environment variables so I was never sure exactly what it was testing it's all a bit too black box for me. It runs rat with exclusions which from my experience in the incubator where most issues show up. It probably works better in the US (where the server is located?) or for people who have better bandwidth connections.
I looked at a build from the saxon changes I just made and can confirm:
- saxon notice files are in source release
- saxon9.jar is in the binary
- asdocs works
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 5:08 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Compiling the SDK worked for me as I said I compiled it and use to to
>test several programs.
Can you explain why compiling the source package worked for you and not
for me? That's worrisome.
>
>> run the ApprovalScript before asking the rest of us to test since the
>>script caught these issues.
>
>The ApprovalScript is not a requirement to test a release, it like any
>other tool such as rat, grep or manual inspection may or may not catch
>any particular issue.
I'm not saying the ApprovalScript is a requirement, I'm saying that that
is what I use, so you can know up front what tests I am going to run so
you can potentially save all of us time by making sure it passes those
tests before offering another RC.
Thanks,
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Compiling the SDK worked for me as I said I compiled it and use to to test several programs.
You can probably use the "-keep-going” option to see if there are any errors beyond the saxon one with the approval script.
> I would like to suggest that before cutting a new RC that we test the
> nightly RC build after you are done making changes.
The nightly RC is constantly being made (and is currently passing), anyone can test that at any time. For this RC I made sure it was passing and waited 24 hours before publishing the RC.
Anyway I have made the changes that should fix the saxon issues and pushed them into the release branch. Changes were minima and only related to the ant build scripts.
Once someone has tested the nighty just post here if there are any other issues, and if there is not I’m make the new RC.
> run the ApprovalScript before asking the rest of us to test since the script caught these issues.
The ApprovalScript is not a requirement to test a release, it like any other tool such as rat, grep or manual inspection may or may not catch any particular issue.
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
I would like to suggest that before cutting a new RC that we test the
nightly RC build after you are done making changes. It would save us all
time if you could run the ApprovalScript before asking the rest of us to
test since the script caught these issues.
-Alex
On 2/15/17, 4:32 PM, "Alex Harui" <ah...@adobe.com> wrote:
>The Approval script died when Saxon wasn't found. I don't know what else
>it needed to test.
>
>I just tried running Ant in the source package. It failed because
>licenseParts/saxon-NOTICES folder wasn't in the source package. Did it
>work for you?
>
>-Alex
>
>On 2/15/17, 4:17 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
>>Hi,
>>
>>So before I cancel the vote and make another RC can I get confirmation
>>that everything else is good?
>>
>>I have tested the SDK with several application and so far no issues so it
>>should be good.
>>
>>Thanks,
>>Justin
>
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
The Approval script died when Saxon wasn't found. I don't know what else
it needed to test.
I just tried running Ant in the source package. It failed because
licenseParts/saxon-NOTICES folder wasn't in the source package. Did it
work for you?
-Alex
On 2/15/17, 4:17 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>So before I cancel the vote and make another RC can I get confirmation
>that everything else is good?
>
>I have tested the SDK with several application and so far no issues so it
>should be good.
>
>Thanks,
>Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
So before I cancel the vote and make another RC can I get confirmation that everything else is good?
I have tested the SDK with several application and so far no issues so it should be good.
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/15/17, 12:27 AM, "justin@classsoftware.com"
<ju...@classsoftware.com> wrote:
>Hi,
>
>> No I did not. I’ll give it a try.
>
>ASDocs seems to work for me but it may be picking up the saxon jar from
>somewhere else, it’s a little hard to tell.
For me, ASDocs did not throw an error but did not generate any HTML files
because Saxon is the XSLT processor. I checked the ASDoc.zip in RC2 and
it also didn't have any html files in it.
>
>I did confirm the jar is missing in the binary so I guess we should
>cancel and fix that minor issue and create another RC. Any thoughts?
So, IMO, this issue needs to be fixed in the source package. I'll bet if
you get the name right in the download script the jar will be bundled in
the binary, so hopefully one fix will fix everything.
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by ju...@classsoftware.com.
Hi,
> No I did not. I’ll give it a try.
ASDocs seems to work for me but it may be picking up the saxon jar from somewhere else, it’s a little hard to tell.
I did confirm the jar is missing in the binary so I guess we should cancel and fix that minor issue and create another RC. Any thoughts?
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I think saxon is only used by ASDoc? Did you try ASDoc?
No I did not. I’ll give it a try.
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/13/17, 10:17 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> Hmm... For me, the source kit doesn't seem to be result in saxon ending
>>up
>> in lib/external/saxon9.jar. Instead it has the full version in the name
>> (saxon9-1-0-8.jar). The binary kit doesn't seem to have saxon in it at
>> all. Do you have it working for you?
>
>I compiled the source SDK and tested applications (web, desktop and
>mobile) against it and they work so yes.
I think saxon is only used by ASDoc? Did you try ASDoc?
>
>The name of the jar is not going to cause any issues, but it would be
>easy enough to rename back to what it was.
Are you sure? I thought if the Java classpath in asdoc.jar says
external/saxon9.jar the jar has to be called saxon9.jar.
-Alex
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Hmm... For me, the source kit doesn't seem to be result in saxon ending up
> in lib/external/saxon9.jar. Instead it has the full version in the name
> (saxon9-1-0-8.jar). The binary kit doesn't seem to have saxon in it at
> all. Do you have it working for you?
I compiled the source SDK and tested applications (web, desktop and mobile) against it and they work so yes.
The name of the jar is not going to cause any issues, but it would be easy enough to rename back to what it was.
The binary missing the jar would be an issue. Ive not had a chance to review the binaries produced in detail yet.
Thanks,
Justin
Re: [DISCUSS] Release Apache Flex SDK 4.16 RC2
Posted by Alex Harui <ah...@adobe.com>.
On 2/11/17, 3:04 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Please discuss the release candidate here and not in the vote thread.
Hmm... For me, the source kit doesn't seem to be result in saxon ending up
in lib/external/saxon9.jar. Instead it has the full version in the name
(saxon9-1-0-8.jar). The binary kit doesn't seem to have saxon in it at
all. Do you have it working for you?
On a good note, the installer can install the binary kit and download the
font kit jars even on my Windows system that fails on the ant download
because I haven't installed the JCE update on that computer yet, so I
think the source forge problem isn't going to affect installer users, but
Ant installer users and folks building from source.
-Alex