You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/10/16 16:49:38 UTC
[PR] test: fold tpcds_planning test into core_integration binary [datafusion]
alamb opened a new pull request, #26422:
URL: https://github.com/apache/datafusion/pull/26422
## Which issue does this PR close?
N/A
## Rationale for this change
Each `.rs` file directly in `datafusion/core/tests` becomes its own test binary, which means extra binary size, extra link time, and tests that cannot run in parallel with tests in other binaries. This follows the same rationale as earlier consolidations (#10588, #11831, #18226) and my previous #26419.
With a normal debug build the standalone `tpcds_planning` binary is **390 MB** (408,695,296 bytes) on my machine (macOS, aarch64).
## What changes are included in this PR?
Move `datafusion/core/tests/tpcds_planning.rs` to `datafusion/core/tests/sql/tpcds_planning.rs` and register it in `sql/mod.rs`, so it is built as part of `core_integration`. The tests are unchanged.
Debug binary sizes:
| binary | bytes |
|---|---|
| `tpcds_planning` (removed) | 408,695,296 |
| `core_integration` before | 457,595,344 |
| `core_integration` after | 458,314,960 (+703 KB) |
So this avoids building and linking a ~390 MB binary at a cost of ~703 KB in `core_integration`.
## What is the testing strategy for this PR?
The tests are unchanged and are run by `core_integration`:
```shell
cargo test -p datafusion --test core_integration -- tpcds
```
All 198 tests pass. `cargo fmt` and `cargo clippy` pass.
## Are there any user-facing changes?
No, developer productivity only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] minor: fold tpcds_planning test into core_integration binary [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26422:
URL: https://github.com/apache/datafusion/pull/26422#issuecomment-6223185696
Let's save some bits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] minor: fold tpcds_planning test into core_integration binary [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #26422:
URL: https://github.com/apache/datafusion/pull/26422#issuecomment-6221383501
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/26422?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.88%. Comparing base ([`1da3cf0`](https://app.codecov.io/gh/apache/datafusion/commit/1da3cf049fa1a7a708acc2c29eba4f2e9dece8db?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`411fdf6`](https://app.codecov.io/gh/apache/datafusion/commit/411fdf6d9fd7dd05a63495451afb87b33dd664f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #26422 +/- ##
==========================================
- Coverage 82.89% 82.88% -0.01%
==========================================
Files 1153 1153
Lines 457487 457487
Branches 457487 457487
==========================================
- Hits 379213 379202 -11
- Misses 55264 55273 +9
- Partials 23010 23012 +2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/26422?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] minor: fold tpcds_planning test into core_integration binary [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #26422:
URL: https://github.com/apache/datafusion/pull/26422#issuecomment-6223187560
Thanks @nuno-faria
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] minor: fold tpcds_planning test into core_integration binary [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #26422:
URL: https://github.com/apache/datafusion/pull/26422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org