[jira] [Commented] (CLOUDSTACK-1241) Network apply rules logic is broken

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576503#comment-13576503 ] 

ASF subversion and git services commented on CLOUDSTACK-1241:
-------------------------------------------------------------

Commit 513f8b98e9b7818d0b37c9641d9021b77a0cfc45 in branch refs/heads/4.1 from [~murali.reddy]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=513f8b9 ]

CLOUDSTACK-1241: Network apply rules logic is broken

added logic to check if the network element is configured service
provider for the network before applying rules

                
> Network apply rules logic is broken
> -----------------------------------
>
>                 Key: CLOUDSTACK-1241
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1241
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.1.0
>            Reporter: Murali Reddy
>            Assignee: Murali Reddy
>            Priority: Critical
>             Fix For: 4.1.0
>
>
> ApplyRules logic in both LoadBalancingRulesManager and FirewallManager loops through all the network elements corresponding to a service. There is no check to ensure that network element is supposed to be provider of the service in that network. Not all network elements are not returning False, in case they fail to apply rule (applyFWRules, applyPFRules, applyStaticNats, applyNetworkACLs, applyLBRules) as they can not handle the rule. This results in applyrules logic to succeed even though rules are not applied on any provider.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira