You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/07/06 10:13:58 UTC
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/778
HAWQ-900. Add dependency in PL/R rpm build spec file plr.spec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq snappy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/778.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #778
----
commit a52139c12cd83bb1f2397cdc9f0ccd032d2eaeab
Author: Paul Guo <pa...@gmail.com>
Date: 2016-07-06T10:09:42Z
HAWQ-900. Add dependency in PL/R rpm build spec file plr.spec
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69842942
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
No, we should not use '=' since we are installing R and R-devel via YUM. Users might have higher version YUM repo. It will be very hard to find the correct YUM repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69844226
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
I guess it would be more proper to test "all" versions of R, not "lastest"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69842622
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
I would prefer: R-devel = 3.1.0 and R = 3.1.0. The reason is that we only certified plr in hawq with R 3.1.0, we don't know if there are any compatible issue R > 3.1.0. Any thought?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69841967
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
--- End diff --
Do we use Apache License 2.0 or 1.1, or just use Apache in general?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69844011
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
Now HAWQ have many dependencies, 'thrift', 'boost', 'curl', etc. Each have the concerns you mentioned.
If this really a concern for plr, then I advise to test with the latest one on both centos6 and centos7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r69843360
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
Suppose uses have R = 3.x (which is higher than 3.1.0) installed with yum. Since we don't try it out in hawq, what if below two potential issue:
1) plr can not be built and installed due to API change in R
2) plr can be build and installed successfully, but have runtime issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r71302626
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
+BuildRequires: R-devel >= 3.1.0
--- End diff --
How about removing the version requirement, if it works fine with R on current rhel 6.x and rhel7?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #778: HAWQ-900. Add dependency in PL/R rpm build spec f...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/778
If the License change is correct. Then +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #778: HAWQ-900. Add dependency in PL/R rpm build spec f...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/778
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #778: HAWQ-900. Add dependency in PL/R rpm build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/778#discussion_r71301383
--- Diff: src/pl/plr.spec ---
@@ -3,10 +3,14 @@ Name: plr-hawq
Version: 08.03.00.14
Release: 0
Prefix: /usr/local
-License: GPL
+License: Apache
--- End diff --
I guess we need to move back to GPL which is exactly the license of PL/R. There has been a upstream PL/R spec file in which license is said to be BSD, but I suspect that is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---