You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2025/09/23 02:11:47 UTC
[PR] [SPARK-53671][PYTHON] Exclude 0-args from `@udf` eval type inference [spark]
zhengruifeng opened a new pull request, #52416:
URL: https://github.com/apache/spark/pull/52416
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Exclude 0-args from `@udf` eval type inference
### Why are the changes needed?
this case fails after https://github.com/apache/spark/pull/52323
```
In [5]: from pyspark.sql.functions import udf
In [6]: @udf()
...: def f1() -> int:
...: return 1
...:
In [7]: spark.range(10).select(f1().alias("res")).collect()
25/09/23 10:08:16 ERROR Executor: Exception in task 0.0 in stage 5.0 (TID 21)
org.apache.spark.api.python.PythonException: Traceback (most recent call last):
File "/Users/ruifeng.zheng/spark/python/lib/pyspark.zip/pyspark/sql/pandas/serializers.py", line 473, in _create_array
return pa.Array.from_pandas(
~~~~~~~~~~~~~~~~~~~~^
series, mask=mask, type=arrow_type, safe=self._safecheck
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "pyarrow/array.pxi", line 1259, in pyarrow.lib.Array.from_pandas
File "pyarrow/array.pxi", line 365, in pyarrow.lib.array
File "pyarrow/array.pxi", line 91, in pyarrow.lib._ndarray_to_array
File "pyarrow/error.pxi", line 92, in pyarrow.lib.check_status
pyarrow.lib.ArrowTypeError: Expected a string or bytes dtype, got int64
The above exception was the direct cause of the following exception:
```
that is due to `f1` is inferred as a `SQL_GROUPED_AGG_PANDAS_UDF`.
I think 0-arg for `SQL_GROUPED_AGG_PANDAS_UDF` doesn't make sense, but to be conservative, I just exclude 0-arg in `@udf` side in this PR. We can revisit the `@pandas_udf` / `@arrow_udf` later.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
added UTs
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53671][PYTHON] Exclude 0-args from `@udf` eval type inference [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #52416:
URL: https://github.com/apache/spark/pull/52416#issuecomment-3325955377
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53671][PYTHON] Exclude 0-args from `@udf` eval type inference [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #52416: [SPARK-53671][PYTHON] Exclude 0-args from `@udf` eval type inference
URL: https://github.com/apache/spark/pull/52416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org