You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/11/23 00:15:17 UTC
[GitHub] incubator-beam pull request #1424: Add input and output types to TransformRe...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/1424
Add input and output types to TransformResult
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This would likely have caught some hard-to-diagnose (for me, new to the runner) type safety errors during the development of `StatefulParDoEvaluatorFactory`, so adding it should hopefully catch similar bugs in the future. As we discussed `InputT` is more useful and reasonable than `OutputT` but there are a number of places where they each line up and might add a little something.
It adds some boilerplate, to be sure, and is still mostly type unsafe since there are lots of methods with generics only on the return type. Opening this for consideration / discussion.
R: @tgroh
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam typed-TransformResult
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1424.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1424
----
commit 4e8a1157a88d8b7ecd64e75c46b0cd6fbbba03ee
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-11-23T00:01:45Z
Add input and output types to TransformResult
This would likely have caught some hard-to-diagnose type safety errors
during the development of StatefulParDoEvaluatorFactory, so adding it
should hopefully catch similar bugs in the future.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1424: Add input type to TransformResult
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/1424
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---