Re: [PR] [SPARK-49097][INFRA] Add Python3 environment detection for the `build_error_docs` method in `build_api_decs.rb` [spark]

["wayneguow (via GitHub)" <gi...@apache.org>]

wayneguow commented on code in PR #47590:
URL: https://github.com/apache/spark/pull/47590#discussion_r1701999774


##########
docs/_plugins/build_api_docs.rb:
##########
@@ -194,7 +194,12 @@ def build_sql_docs
 
 def build_error_docs
   print_header "Building error docs."
-  system("python '#{SPARK_PROJECT_ROOT}/docs/util/build-error-docs.py'") \
+
+  if !system("which python3 >/dev/null 2>&1")
+    raise("Missing python3 in your path, stopping error doc generation")
+  end
+
+  system("python3 '#{SPARK_PROJECT_ROOT}/docs/util/build-error-docs.py'") \

Review Comment:
   Since users may not use python venv, I suggest changing to `python3` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org