You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2023/11/18 00:33:13 UTC
[PR] ConnectionTracker: Remove queue implementation [trafficserver]
bneradt opened a new pull request, #10825:
URL: https://github.com/apache/trafficserver/pull/10825
Connection count queueing functionality was removed via #7302. This removes some dead code that was still associated with that now-removed feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ConnectionTracker: Remove queue implementation [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #10825:
URL: https://github.com/apache/trafficserver/pull/10825#discussion_r1398012867
##########
src/proxy/http/HttpSM.cc:
##########
@@ -5884,9 +5884,6 @@ HttpSM::handle_post_failure()
void
HttpSM::handle_http_server_open()
{
- // The request is now not queued. This is important because server retries reuse the t_state.
- t_state.outbound_conn_track_state.dequeue();
-
Review Comment:
This might seem like a concerning removal of a use of dequeue, but note that enqueue was never called. Thus this call was always a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ConnectionTracker: Remove queue implementation [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #10825:
URL: https://github.com/apache/trafficserver/pull/10825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org