[jira] [Commented] (HIVE-9642) Hive metastore client retries don't happen consistently for all api calls

["Thejas M Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337036#comment-14337036 ] 

Thejas M Nair commented on HIVE-9642:
-------------------------------------

Looks good. Just a minor nit , the javadoc has  "@inheritDoc" and this is adding a partial javadoc of this function "@throws" to it . Can you remove that "@throws" that got added ? (the full javadoc is available via the superclass).



> Hive metastore client retries don't happen consistently for all api calls
> -------------------------------------------------------------------------
>
>                 Key: HIVE-9642
>                 URL: https://issues.apache.org/jira/browse/HIVE-9642
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HIVE-9642.1.patch, HIVE-9642.2.patch
>
>
> When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout, the retry via RetryingMetaStoreClient happens only in certain cases.
> Retry happens for the getDatabase call in but not for getAllDatabases().
> The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException. But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain functions in HMC.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)