You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/09/28 10:50:47 UTC
[GitHub] [fineract] renovate-bot opened a new pull request #1355: Update dependency org.flywaydb:flyway-core to v7
renovate-bot opened a new pull request #1355:
URL: https://github.com/apache/fineract/pull/1355
This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| [org.flywaydb:flyway-core](org/flywaydb/flyway-core) | major | `6.5.7` -> `7.0.0` |
---
### Renovate configuration
:date: **Schedule**: At any time (no schedule defined).
:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/apache/fineract).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703247061
Looks like Flyway brings in AWS SDK v2, whereas we are using v1... so easiest fix will probably be to change our code to use the SDK v2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703113180
@xurror resolving this is perhaps something "up your ally" (something that interests you) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703272529
Closing, as #1367 actually passed the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703256241
@vorburger Looks like they've added support for AWS S3 into Flyway, so it now has the AWS SDK as a dependency: https://github.com/flyway/flyway/pull/2458
I wasn't able to find any "stripped down" Flyway distribution when I looked - but I agree excluding the AWS dependency is likely to work, so I can try that a bit later.
At the same time, I do think moving to AWS SDK v2 would also be a sensible move - surely we would anyway want to use the latest version of the SDK...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger closed pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #1355:
URL: https://github.com/apache/fineract/pull/1355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703264707
> I wasn't able to find any "stripped down" Flyway distribution when I looked
Yeah, looks like they're not big on proper modularity, seeing https://github.com/flyway/flyway/blob/master/flyway-core/pom.xml. They do however use `<optional>true`, see https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html.
Initially I suspected that Gradle simply doesn't dig `<optional>true` in Maven POMs, and glanced at https://blog.gradle.org/optional-dependencies and https://docs.gradle.org/current/userguide/feature_variants.html seem to be related to that.
Then I noticed that `software.amazon.awssdk:s3` is the ONLY (of many) deps in Flyway that is NOT `<optional>true`. That does not seem right, to me. I'll raise a PR for Flyway to propose they make it optional in their next release. Others seem to have noticed that as well, note https://github.com/flyway/flyway/issues/2957.
> but I agree excluding the AWS dependency is likely to work, so I can try that a bit later.
Agreed, this seems like the best solution for the very short term, so I'm proposing that in #1367 (not yet tested).
> At the same time, I do think moving to AWS SDK v2 would also be a sensible move - surely we would anyway want to use the latest version of the SDK...
Separate, later? :smile:
@ptuomola OK for you to close this PR, with follow-up in #1367?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] forking-renovate[bot] commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
forking-renovate[bot] commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703272616
### Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for *any* future 7.x releases. However, if you upgrade to 7.x manually then Renovate will then reenable updates for minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-703253613
Hm, but.. something doesn't entirely make sense here, to me. WHY does
Flyway need the AWS SDK?! They probably added direct support for migration
of some managed AWS DB. But.. we don't need that! Instead of having to
upgrade our code just because of this, we should be able to simply exclude
the transitive artifact? Or, better... we likely have the "wrong" Flyway
dependency - like should we really be using some sort of "-mysql" instead
of "-all" Flyway artifact instead, do you know what I mean? (I've not
actually checked, but have resolved similar problems for other dependencies
like that in the past.)
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1355: Update dependency org.flywaydb:flyway-core to v7
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1355:
URL: https://github.com/apache/fineract/pull/1355#issuecomment-700176133
This fails the build (so DO NOT MERGE, until fixed), due to:
```
org.apache.fineract.infrastructure.classdupes.ClasspathHellDuplicatesCheckRuleTest > testIfThereAreAnyDuplicatesOnTheClasspath() FAILED
org.opentest4j.AssertionFailedError: 1 Classpath duplicates detected:
mime.types
jar:file:/home/travis/.gradle/caches/modules-2/files-2.1/com.amazonaws/aws-java-sdk-s3/1.11.852/6fa5cbbace7519ca716c45bddd11165d1baa76b1/aws-java-sdk-s3-1.11.852.jar!/mime.types
jar:file:/home/travis/.gradle/caches/modules-2/files-2.1/software.amazon.awssdk/sdk-core/2.10.56/e8ebab9b0b91374d62cb58ea692ab54188d2d23a/sdk-core-2.10.56.jar!/mime.types
at org.apache.fineract.infrastructure.classdupes.ClasspathHellDuplicatesCheckExtension.checkClasspath(ClasspathHellDuplicatesCheckExtension.java:64)
```
Although why a Flyway upgrade pulls along another presumably newer version of amazonaws is kind of curious.
I don't have time to have a closer look right now, so anyone else interested can (do e.g. a `./gradlew dependencies` ? etc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org