You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/21 01:01:30 UTC

[GitHub] [maven-checkstyle-plugin] hazendaz opened a new pull request #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b…

hazendaz opened a new pull request #25: [MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change b…
URL: https://github.com/apache/maven-checkstyle-plugin/pull/25

…ack to 'null' default

The severity setting even on original logic is incorrect. It must remain null if it is to work properly at all. While counts in fact are off, the entire section will be lost if it doesn't contain issues in at least 'error' due to the change when using default configurations. This has to be reverted as not originally fixed properly so that the rules aggregate will display. Example case has no 'error' type, only 'warning'. Changing this to 'warning' will pick that section up. Using 'info' or 'error' fails to do so. I didn't bother with checking 'ignore' as that most likely is not good use either. There is definitely a bug here as originally designed and more care needs taken to fix properly. Sample project used to confirm was 'mybatis-3' master from github which has only checkstyle warnings.

Following this checklist to help us incorporate your
contribution quickly and easily:

- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).

If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.

- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)

- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services