You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by priyank5485 <gi...@git.apache.org> on 2017/05/19 22:36:53 UTC

[GitHub] storm issue #2126: Add the option to set client.id to storm-kafka and storm-...

Github user priyank5485 commented on the issue:

    https://github.com/apache/storm/pull/2126
  
    @carl34  We already have setProp method in KafkaSpoutConfig in storm-kafka-client that can be used to set any producer property. I dont think this adds any value. Can you elaborate on why you need that method? As far as the storm-kafka module is concerned that property is already public. I dont see a reason for adding one more constructor argument. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---